-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent validator errors/retries on read timeouts #1056
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1056 +/- ##
=======================================
Coverage 92.90% 92.90%
=======================================
Files 67 67
Lines 3790 3790
=======================================
Hits 3521 3521
Misses 269 269
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Co-authored-by: Casper Welzel Andersen <43357585+CasperWA@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cheers. Seems you also upped the default readout time to 60 s - I presume this is intentional and not from some local changes and testing? :)
Yeah, its in the description above, it seems that some of the bigger validator queries reliably hit 30 seconds for some implementations, so I've upped the default. |
The last PR (#1051) introduced explicit read timeouts and reduced the default value to 30 seconds. After some testing with the dashboard, 30 seconds is quite a harsh timeout for some implementations/requests, so this is now increased to 2 minutes by default. Also, as
requests.exceptions.ReadTimeout
does not subclassrequests.exceptions.ConnectionError
, these requests were failing with "internal" validator errors, rather than being handled as errors related to the implementation.This PR fixes that error handling, and additionally prevents read timeouts from triggering retries. A CLI arg was also added for
--read-timeout
for easier testing.