-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cancel CI PR jobs that are in progress with new changes, add skip_changelog label to overrides #1057
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1057 +/- ##
=======================================
Coverage 92.90% 92.90%
=======================================
Files 67 67
Lines 3790 3790
=======================================
Hits 3521 3521
Misses 269 269
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This confuses me. You are now excluding all PRs with a |
Yes, I thought the CI changelog change is a minor one so added it alongside this CI tweak. Another option would be to add a special label "skip_changelog" that we can use to manually override the rule. Do you think CI changes should be in the changelog? |
A |
Fair point, I guess we can push the quibbling to whether each individual PR should have a |
86e6973
to
6a69a8a
Compare
Not sure that should be the case either. I like a chunky changelog 😅 Even if each line represents a few character changes in the code base... Depending on the characters changed the PR may be significant or not ;) |
6a69a8a
to
779f591
Compare
Hmm, I guess this is an important point then. To me, our changelog is user-facing (where user could include anyone who depends on this library) and not developer facing. But I guess your issue with the "Update Dependency" entries was more the repetition (and lack of info)? I'm not overly fussed either way, if |
779f591
to
4da9bdd
Compare
(The cancel in progress thing works nicely though, should save us some build minutes across here and the dashboard builds) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not see anything wrong with this PR.
I do not know much about GitHub actions, though, so a mistake could easily have slipped past me.
I think @CasperWA and I reached agreement on the labelling, so I will merge this now |
As above. This PR will cancel workflows from running when new changes are pushed to a PR.