-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Jinja dependency for landing page generation #1082
Conversation
824b97c
to
788b1e4
Compare
Codecov Report
@@ Coverage Diff @@
## master #1082 +/- ##
==========================================
- Coverage 92.90% 92.51% -0.39%
==========================================
Files 67 67
Lines 3790 3807 +17
==========================================
+ Hits 3521 3522 +1
- Misses 269 285 +16
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This essentially looks fine to me - cheers @ml-evs.
I have left some comments and suggested changes, but they are not at all critical - at least not if this works on your end as intended. I can try and test it as well, but if you already did, I trust your work.
Co-authored-by: Casper Andersen <casper.w.andersen@sintef.no>
Have tested this again locally, so will merge without a re-review. |
|
Yup. Created issue #1086 for this now :/ |
Alleviates the issues with the Jinja+aiida dep combination (#1079) by manually constructing and caching the landing page.
The info displayed should be identical, except it is no longer sanitized to check for web-safety of the metadata.