-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for number-based pagination #1139
Add support for number-based pagination #1139
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1139 +/- ##
=======================================
Coverage 92.41% 92.42%
=======================================
Files 68 68
Lines 3904 3909 +5
=======================================
+ Hits 3608 3613 +5
Misses 296 296
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Just rebasing this PR to see how it interacts with #1141 |
8fa1597
to
37cdf26
Compare
Lots of GitHub actions failures this morning, will try again later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor comment then I think this is ready! I will release 0.17.0 after this and another round of dependency PRs.
21ab8af
to
ccaa99d
Compare
…in the case of paging so ids of documents that are not returned on this page do not have to be specified.
…hen the sorting takes place on a field other than id.
Co-authored-by: Matthew Evans <7916000+ml-evs@users.noreply.github.com>
…rs are supplied. Co-authored-by: Matthew Evans <7916000+ml-evs@users.noreply.github.com>
…arameters are set.
- If a single ID is passed as a string, validate the request as a single entry request - If a single ID is passed within a list, validate it is a multi-entry request that only returns one result
ccaa99d
to
d53cc06
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM now @JPBergsma, I will merge once the tests pass, then release 0.17!
In this PR I have added support for the
page_number
query parameter, as already mentioned in #1132.I have also added a test for this.
I had not realized that I also had to add the IDs that are not in the response but do meet the requirements of the filter.
I therefore adjusted the 'check_response' function, so this is no longer necessary.
This also required changing another test.
Finally, I now also sort the response IDs as the sort in python could be done differently than the sort in the query.