-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A few fixes related to usage as a library #119
Conversation
Codecov Report
@@ Coverage Diff @@
## master #119 +/- ##
==========================================
- Coverage 82.81% 82.73% -0.09%
==========================================
Files 39 39
Lines 1810 1813 +3
==========================================
+ Hits 1499 1500 +1
- Misses 311 313 +2
Continue to review full report at Codecov.
|
This should be possible also with the
Huh, thought I fixed that earlier - probably missed it. Thanks! 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @ml-evs!
Have you tried to test if the package data is included with the new setup?
- Added all json and cfg files to package data - Changed default paths for index_links and config.ini to the server dir for the install, not the top-level dir.
Use proper relative paths for creating the local OpenAPI JSON files.
I have updated the README with information on where to put |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is firing on all cylinders now, thanks @ml-evs!
This PR mostly contains fixes that allow this package to be used as a library (i.e. non-editable install).
optimade.config
to look in the cwd instead of optimade install directory forserver.cfg
file and moved theserver_template.cfg
into the server directory so it can be included as package data.package_data
fromsetup.py
in lieu of explicitly specifying all test data and associated config files inMANIFEST.in
.Aside from that, it fixes some small issues:
data_returned: 1
when the structure is not found.