-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapters now also return lattice information for structures that are periodic in 1 or 2 dimensions. #1233
Adapters now also return lattice information for structures that are periodic in 1 or 2 dimensions. #1233
Conversation
…al_coordinates function are generated correctly. 2. Added support to the cif, pymatgen and proteindatabank adapters for generating lattice data for structures that are not periodic in all three dimensions.
Codecov Report
@@ Coverage Diff @@
## master #1233 +/- ##
==========================================
+ Coverage 90.81% 90.90% +0.08%
==========================================
Files 72 72
Lines 4357 4364 +7
==========================================
+ Hits 3957 3967 +10
+ Misses 400 397 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
…rk under python 3.7. Also nperiodic_dimensions is now calculated in the function null_lattice_vector_structure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, there's no objections from anyone else, so this is fine with me. Thanks @JPBergsma
This PR fixes a bug in testing whether fractional coordinates are generated correctly, and enables the returning of lattice information in the pymatgen, proteindatabank and cif adapters for structures that are periodic in less than three dimensions.
closes #1232 closes #1212