Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update requirements #138

Merged
merged 2 commits into from
Jan 17, 2020
Merged

Update requirements #138

merged 2 commits into from
Jan 17, 2020

Conversation

CasperWA
Copy link
Member

@CasperWA CasperWA commented Jan 17, 2020

Make available for installs on Py3.6 environments.

Since this makes it installable for "older" Py3 versions, I have upped the patch version, i.e., new version v0.3.1.

Added minimum Django requirement to be v2.2.9 for security reasons.

@CasperWA CasperWA requested a review from ml-evs January 17, 2020 16:04
Make available for installs on Py3.6 environments.
@codecov
Copy link

codecov bot commented Jan 17, 2020

Codecov Report

Merging #138 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #138   +/-   ##
=======================================
  Coverage   84.86%   84.86%           
=======================================
  Files          39       39           
  Lines        1817     1817           
=======================================
  Hits         1542     1542           
  Misses        275      275
Flag Coverage Δ
#unittests 84.86% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af87544...6fbd45d. Read the comment docs.

@CasperWA CasperWA requested a review from ltalirz January 17, 2020 16:56
@ml-evs
Copy link
Member

ml-evs commented Jan 17, 2020

lgtm, can you just remind me of what pydantic=~1.3 is doing in setup.py? If I have 1.1 installed will it update it, or is it only if I have pydantic<1?

@CasperWA
Copy link
Member Author

CasperWA commented Jan 17, 2020

lgtm, can you just remind me of what pydantic=~1.3 is doing in setup.py? If I have 1.1 installed will it update it, or is it only if I have pydantic<1?

It shouldn't will change it , I believe. The ~= just makes sure you have "circa" the version specified, where it is allowed to be newer on the last digit, i.e., ~=1.1 will install v1.3 on a fresh install. I don't exactly know about an install that already has v1.1, but I guess it shouldn't do anything? I can check!

Edit: It will install the one specified if it is newer (this is without -U, it will definitely install the latest with -U).

@CasperWA CasperWA merged commit 69d215c into master Jan 17, 2020
@CasperWA CasperWA deleted the add_py36 branch January 17, 2020 18:01
@ml-evs
Copy link
Member

ml-evs commented Jan 17, 2020

lgtm, can you just remind me of what pydantic=~1.3 is doing in setup.py? If I have 1.1 installed will it update it, or is it only if I have pydantic<1?

It shouldn't will change it , I believe. The ~= just makes sure you have "circa" the version specified, where it is allowed to be newer on the last digit, i.e., ~=1.1 will install v1.3 on a fresh install. I don't exactly know about an install that already has v1.1, but I guess it shouldn't do anything? I can check!

Edit: It will install the one specified if it is newer (this is without -U, it will definitely install the latest with -U).

Cheers, I got confused with this before, so ~=1.3 is equivalent to >=1.3,<2

@CasperWA
Copy link
Member Author

lgtm, can you just remind me of what pydantic=~1.3 is doing in setup.py? If I have 1.1 installed will it update it, or is it only if I have pydantic<1?

It shouldn't will change it , I believe. The ~= just makes sure you have "circa" the version specified, where it is allowed to be newer on the last digit, i.e., ~=1.1 will install v1.3 on a fresh install. I don't exactly know about an install that already has v1.1, but I guess it shouldn't do anything? I can check!
Edit: It will install the one specified if it is newer (this is without -U, it will definitely install the latest with -U).

Cheers, I got confused with this before, so ~=1.3 is equivalent to >=1.3,<2

That seems to be the case with my small test, yes. And ~=1.3.0 is then equivalent to >=1.3.0,<1.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants