Allow empty strings through chemical formula regexp #1428
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last PR of the day, and one that can actually be reviewed and merged.
After discussions in Materials-Consortia/OPTIMADE#388, it seems that empty formulae should be allowed -- though we should wait until it is really resolved to merge this.
This PR adjusted the regexp for this and moves the test case around.
This has knock-on effects on open PRs in other repos (schemas, specification) that will need to be untangled at a later date.