-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add meta field to entry model #1698
base: 0.25.x
Are you sure you want to change the base?
Add meta field to entry model #1698
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1698 +/- ##
==========================================
+ Coverage 90.68% 90.78% +0.09%
==========================================
Files 74 74
Lines 4616 4665 +49
==========================================
+ Hits 4186 4235 +49
Misses 430 430
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This reverts commit 6251e48.
This reverts commit bf9692a.
…/optimade-python-tools into JPBergsma/add_metadata
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @JPBergsma, this is nice. Very minor suggestions below.
Let's have a chat on Monday about the best way of merging this (and the other 1.2 features).
update description property_metadata field Co-authored-by: Matthew Evans <7916000+ml-evs@users.noreply.github.com>
This reverts commit 68f14d3.
removed duplicate requirement
* Use Python 3.9 as the 'base' CI version for linting * Update pre-commit hooks * Run `pyupgrade --py39-plus` to upgrade legacy annotations * Add `--exit-non-zero-on-fix` for ruff Co-authored-by: Casper Welzel Andersen <43357585+CasperWA@users.noreply.github.com> * Use f-string over format Co-authored-by: Casper Welzel Andersen <43357585+CasperWA@users.noreply.github.com> --------- Co-authored-by: Casper Welzel Andersen <43357585+CasperWA@users.noreply.github.com>
I am trying to add support for the metadata field as described in issue #1697
It is still a work in progress, as I still need to add tests and validators, but comments are welcome.