Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to v0.5.0 #179

Merged
merged 1 commit into from
Feb 13, 2020
Merged

Bump to v0.5.0 #179

merged 1 commit into from
Feb 13, 2020

Conversation

CasperWA
Copy link
Member

Since the API is changed (very slightly), we should actually up the major version, however, since the package/repository is still under development - and we are not extremely compliant with SemVer, I think it's okay to bump "just" the minor version instead.

Changes:

Bug fixes:

@codecov
Copy link

codecov bot commented Feb 13, 2020

Codecov Report

Merging #179 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #179   +/-   ##
=======================================
  Coverage   86.31%   86.31%           
=======================================
  Files          40       40           
  Lines        1878     1878           
=======================================
  Hits         1621     1621           
  Misses        257      257
Flag Coverage Δ
#unittests 86.31% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae324fc...8c789e6. Read the comment docs.

@CasperWA CasperWA marked this pull request as ready for review February 13, 2020 17:39
Copy link
Member

@ml-evs ml-evs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My understanding of semver is that it stipulates that you can do what you want to the API before v1 anyway, so think we're still in the clear!

@CasperWA CasperWA merged commit 5f8efab into master Feb 13, 2020
@CasperWA CasperWA deleted the bump_to_v0.5.0 branch February 13, 2020 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants