Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codecov-action supports token-less uploads #220

Merged
merged 1 commit into from
Mar 9, 2020

Conversation

CasperWA
Copy link
Member

@CasperWA CasperWA commented Mar 9, 2020

Removed secret token from the workflow, since the codecov-action now supports token-less uploads for public GitHub repositories. To make sure we only upload to Codecov for the upstream repository (Materials-Consortia/optimade-python-tools) an additional condition for when to upload is added to the upload step.

Added pydantic to requirements_eager.txt.

Using actions/checkout@master, since v2 is not up-to-date, and codecov-action will not work for v2.
Note: This should be updated as soon as they have an up-to-date version.

@CasperWA CasperWA added dependency_updates Issues pertaining to updates to our dependencies that are breaking the eager build CI Continuous Integration - GitHub Actions issues (NOT related to the repository Action) labels Mar 9, 2020
@CasperWA CasperWA requested a review from ml-evs March 9, 2020 16:19
@codecov
Copy link

codecov bot commented Mar 9, 2020

Codecov Report

Merging #220 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #220   +/-   ##
=======================================
  Coverage   87.15%   87.15%           
=======================================
  Files          42       42           
  Lines        1892     1892           
=======================================
  Hits         1649     1649           
  Misses        243      243
Flag Coverage Δ
#unittests 87.15% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe05bd3...351da96. Read the comment docs.

Removed secret token since the codecov-action now supports token-less
uploads for public GitHub repositories.
To make sure we only upload to Codecov for the upstream repository an
additional condition for when to upload is added to the upload step.

Added pydantic to requirements_eager.txt.

Using actions/checkout@master, since v2 is not up-to-date, and
codecov-action will not work for v2.
NOTE: This should be updated as soon as they have an up-to-date version.
Copy link
Member

@ml-evs ml-evs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks sensible, thanks @CasperWA. I'm assuming the pydantic change is to allow dependabot to get us to the latest version that fastapi supports (and that it can handle second-order deps like this)?

@CasperWA
Copy link
Member Author

CasperWA commented Mar 9, 2020

This looks sensible, thanks @CasperWA. I'm assuming the pydantic change is to allow dependabot to get us to the latest version that fastapi supports (and that it can handle second-order deps like this)?

Actually, I haven't added these CI requirements.txt to dependabot. It was merely to make sure the "eager CI workflow" installs the latest version of pydantic.

@CasperWA
Copy link
Member Author

CasperWA commented Mar 9, 2020

This looks sensible, thanks @CasperWA. I'm assuming the pydantic change is to allow dependabot to get us to the latest version that fastapi supports (and that it can handle second-order deps like this)?

However, it indeed seems that dependabot can handle second-order dependencies.

Currently it checks/monitors:

  • Pipfile
  • setup.cfg
  • setup.py

@CasperWA CasperWA merged commit 98adbb2 into Materials-Consortia:master Mar 9, 2020
@CasperWA CasperWA deleted the minor_fixes_to_CI branch March 9, 2020 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration - GitHub Actions issues (NOT related to the repository Action) dependency_updates Issues pertaining to updates to our dependencies that are breaking the eager build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants