Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new action for publishing #377

Merged
merged 19 commits into from
Jun 26, 2020
Merged

Use new action for publishing #377

merged 19 commits into from
Jun 26, 2020

Conversation

CasperWA
Copy link
Member

@CasperWA CasperWA commented Jun 26, 2020

New publish workflow

I have jumbled together a Docker-based GitHub Action push-protected.

It's main purpose is to facilitate pushing to protected branches.
It will go through the following workflow:

  1. Apply changes to the current state of the target protected branch (e.g., updating CHANGELOG.md).
  2. Determine required checks for the target protected branch (e.g., master).
  3. Create a dummy branch, which includes the applied changes.
    Push it so that the same required checks needed for the target protected branch are run on the dummy branch (these branches are named: push-action/<run ID>/<UUID>, where <run ID> is the current Action workflow run's ID).
  4. Wait for all required checks to pass on dummy branch.
  5. Merge dummy branch into protected branch (using --ff-only, i.e., fast forward).
  6. Remove dummy branch (also remove it no matter if the workflow fails or succeeds).

So essentially in this way there will be no PR generated, which can be messed up unintentionally.
There will be no changing the protection on the protected branch.
However, it will be slow, and since it's a Docker-based Action, all changes need to done within the Action itself. This is sorted by having a bash script in the repo that can be referenced in the workflow yml-file, downloaded by the action and then run.

Other changes

  • Remove yml option for the Upload codecov action (it is no longer available).
  • Update to the latest release, v0.9.4
  • Remove check_released_tag.py, since it is no longer needed.
  • Add a docs extra to setup.py.
  • Update dependencies in setup.py according to the various updated requirements files.

@CasperWA CasperWA added enhancement New feature or request dependency_updates Issues pertaining to updates to our dependencies that are breaking the eager build tests Related to tests CI Continuous Integration - GitHub Actions issues (NOT related to the repository Action) labels Jun 26, 2020
@CasperWA CasperWA requested review from ml-evs and shyamd June 26, 2020 14:51
@codecov
Copy link

codecov bot commented Jun 26, 2020

Codecov Report

Merging #377 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #377   +/-   ##
=======================================
  Coverage   90.27%   90.27%           
=======================================
  Files          54       54           
  Lines        2386     2386           
=======================================
  Hits         2154     2154           
  Misses        232      232           
Flag Coverage Δ
#unittests 90.27% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c02fbd2...5511218. Read the comment docs.

@shyamd
Copy link
Contributor

shyamd commented Jun 26, 2020

Looks good to me. Let's try it.

@CasperWA CasperWA merged commit 96428ba into master Jun 26, 2020
@CasperWA CasperWA deleted the use_new_action branch June 26, 2020 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration - GitHub Actions issues (NOT related to the repository Action) dependency_updates Issues pertaining to updates to our dependencies that are breaking the eager build enhancement New feature or request tests Related to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants