-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use new action for publishing #377
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CasperWA
added
enhancement
New feature or request
dependency_updates
Issues pertaining to updates to our dependencies that are breaking the eager build
tests
Related to tests
CI
Continuous Integration - GitHub Actions issues (NOT related to the repository Action)
labels
Jun 26, 2020
Getting version directly from __init__.py now.
Use temporary versions for invoke task
Set version to 0.9.4 Remove mentions of test_release branch
Codecov Report
@@ Coverage Diff @@
## master #377 +/- ##
=======================================
Coverage 90.27% 90.27%
=======================================
Files 54 54
Lines 2386 2386
=======================================
Hits 2154 2154
Misses 232 232
Continue to review full report at Codecov.
|
Looks good to me. Let's try it. |
shyamd
approved these changes
Jun 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CI
Continuous Integration - GitHub Actions issues (NOT related to the repository Action)
dependency_updates
Issues pertaining to updates to our dependencies that are breaking the eager build
enhancement
New feature or request
tests
Related to tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New publish workflow
I have jumbled together a Docker-based GitHub Action push-protected.
It's main purpose is to facilitate pushing to protected branches.
It will go through the following workflow:
CHANGELOG.md
).master
).Push it so that the same required checks needed for the target protected branch are run on the dummy branch (these branches are named:
push-action/<run ID>/<UUID>
, where<run ID>
is the current Action workflow run's ID).--ff-only
, i.e., fast forward).So essentially in this way there will be no PR generated, which can be messed up unintentionally.
There will be no changing the protection on the protected branch.
However, it will be slow, and since it's a Docker-based Action, all changes need to done within the Action itself. This is sorted by having a bash script in the repo that can be referenced in the workflow yml-file, downloaded by the action and then run.
Other changes
yml
option for the Upload codecov action (it is no longer available).Update to the latest release, v0.9.4check_released_tag.py
, since it is no longer needed.docs
extra tosetup.py
.setup.py
according to the various updated requirements files.