-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set implementation version in config by default #385
Set implementation version in config by default #385
Conversation
Codecov Report
@@ Coverage Diff @@
## master #385 +/- ##
==========================================
+ Coverage 90.22% 90.24% +0.01%
==========================================
Files 55 55
Lines 2404 2408 +4
==========================================
+ Hits 2169 2173 +4
Misses 235 235
Continue to review full report at Codecov.
|
I chose to do this via the default values in the config so that someone using a modified version of our server could update the implementation. Your code also overrides the provider no matter who is using it. |
It doesn't override. It sets the defaults first, then updates the values with the provided ones - the same for the |
Just to clarify, we have no way of knowing how to fill in the |
Set config defaults for `provider` and `implementation`. This ensures that the `version` field is set for `implementation`.
311a7d1
to
224a7a8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Set config defaults for
provider
andimplementation
.This ensures that the
version
field is set forimplementation
.Maybe all of this is not needed?
But it's important to get the
version
sub-field automated here.