Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit only when necessary #495

Merged
merged 2 commits into from
Sep 11, 2020

Conversation

CasperWA
Copy link
Member

The update_docs.sh script used to update the changelog and more upon a new release is set to exit at any time if a return value different than 0 occurs (set -e).

Since git will return a non-zero value if trying to commit and there's nothing to commit, a check for this has been added to update_docs.sh.

It is not done for the second git commit line, since if there is no CHANGELOG to commit, I would suspect there shouldn't be a release at all. However, this can be argued against.

@CasperWA CasperWA added bug Something isn't working CI Continuous Integration - GitHub Actions issues (NOT related to the repository Action) labels Sep 11, 2020
@codecov
Copy link

codecov bot commented Sep 11, 2020

Codecov Report

Merging #495 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #495   +/-   ##
=======================================
  Coverage   91.58%   91.58%           
=======================================
  Files          61       61           
  Lines        3103     3103           
=======================================
  Hits         2842     2842           
  Misses        261      261           
Flag Coverage Δ
#project 91.58% <ø> (ø)
#validator 63.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d04d3fe...08af940. Read the comment docs.

@ml-evs ml-evs merged commit 9f42a54 into Materials-Consortia:master Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CI Continuous Integration - GitHub Actions issues (NOT related to the repository Action)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants