Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make validator respond to KeyboardInterrupts #505

Merged
merged 2 commits into from
Sep 18, 2020

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented Sep 18, 2020

Otherwise you have to mash Ctrl-C until it causes an UnboundLocalError further up the chain.

@ml-evs ml-evs added priority/low Issue or PR with a consensus of low priority validator Related to the OPTIMADE validator labels Sep 18, 2020
@codecov
Copy link

codecov bot commented Sep 18, 2020

Codecov Report

Merging #505 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #505   +/-   ##
=======================================
  Coverage   91.59%   91.59%           
=======================================
  Files          61       61           
  Lines        3118     3118           
=======================================
  Hits         2856     2856           
  Misses        262      262           
Flag Coverage Δ
#project 91.59% <100.00%> (ø)
#validator 63.72% <33.33%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
optimade/validator/utils.py 90.29% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56a4d0c...6a86c2d. Read the comment docs.

Copy link
Member

@CasperWA CasperWA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just updating all the sugar as well, and minifying your solution :)

optimade/validator/utils.py Outdated Show resolved Hide resolved
optimade/validator/utils.py Show resolved Hide resolved
optimade/validator/utils.py Outdated Show resolved Hide resolved
optimade/validator/utils.py Outdated Show resolved Hide resolved
@ml-evs
Copy link
Member Author

ml-evs commented Sep 18, 2020

Just updating all the sugar as well, and minifying your solution :)

Yet another rapid and thorough code review... if you're still up then I have to stay up for at least another hour 😁

(not really 💤 )

@CasperWA
Copy link
Member

Just updating all the sugar as well, and minifying your solution :)

Yet another rapid and thorough code review... if you're still up then I have to stay up for at least another hour 😁

Don't do it! 😅 ... 😓

Copy link
Member

@CasperWA CasperWA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers @ml-evs 👍

@ml-evs ml-evs merged commit 0ec8d8e into master Sep 18, 2020
@ml-evs ml-evs deleted the ml-evs/validator_kb_interrupt branch September 18, 2020 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/low Issue or PR with a consensus of low priority validator Related to the OPTIMADE validator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants