Fix landing page URL

[shyamd]

This should fix the endpoint URLs on the landing page to use the proper base_url rather than what comes in from the request.

EDIT: clearly the commit names are screwed up. One is for fixing the landing page and the other ensures get_base_url returns consistent base URLs without the trailing slash.

Closes #371.

[codecov]

Codecov Report

Merging #519 into master will decrease coverage by 0.04%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##           master     #519      +/-   ##
==========================================
- Coverage   91.55%   91.51%   -0.05%     
==========================================
  Files          62       62              
  Lines        3127     3123       -4     
==========================================
- Hits         2863     2858       -5     
- Misses        264      265       +1     

Flag	Coverage Δ
#project	91.51% <85.71%> (-0.05%)	⬇️
#validator	63.68% <80.95%> (-0.08%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
optimade/server/exception_handlers.py	82.81% <ø> (ø)
optimade/server/routers/index_info.py	100.00% <ø> (ø)
optimade/server/routers/info.py	95.65% <ø> (-0.51%)	⬇️
optimade/server/routers/landing.py	70.58% <60.00%> (+1.83%)	⬆️
optimade/server/routers/utils.py	96.99% <88.88%> (-0.74%)	⬇️
optimade/server/middleware.py	94.93% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7bc4596...09ed18c. Read the comment docs.

[CasperWA]

Testing this locally, using run.sh while setting OPTIMADE_BASE_URL to something weird (http://localhost:5000/test/yir), seems to make sense:

[CasperWA]

Testing this locally, using run.sh while setting OPTIMADE_BASE_URL to something weird (http://localhost:5000/test/yir), seems to make sense:

The same is true if I add a / to the end of that env variable, i.e., OPTIMADE_BASE_URL=http://localhost:5000/test/yir/.

Of course, using run.sh the server will still run on http://localhost:5000, but the correct base URL shown on the landing page is at least what would be expected from the configuration.

[CasperWA]

Cheers @shyamd

I wonder if the utility function get_base_url should support both parsed url instances as well as str, parsing it in the function itself... It would probably remove a couple of lines in the code overall - perhaps? But this can be done in another PR.

[ml-evs]

This LGTM, thanks @shyamd and @CasperWA