Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This should ensure requirements*.txt are tested #527

Merged
merged 1 commit into from
Sep 24, 2020
Merged

This should ensure requirements*.txt are tested #527

merged 1 commit into from
Sep 24, 2020

Conversation

CasperWA
Copy link
Member

@CasperWA CasperWA commented Sep 24, 2020

By first installing the package and then from the requirements*.txt files this should ensure we test the correct versions when dependabot opens PRs.

See my comment here for an example of where this has happened.

By first installing the package and then from the requirements*.txt
files this should ensure we test the correct versions when dependabot
opens PRs.
Copy link
Member

@ml-evs ml-evs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov
Copy link

codecov bot commented Sep 24, 2020

Codecov Report

Merging #527 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #527   +/-   ##
=======================================
  Coverage   91.51%   91.51%           
=======================================
  Files          62       62           
  Lines        3123     3123           
=======================================
  Hits         2858     2858           
  Misses        265      265           
Flag Coverage Δ
#project 91.51% <ø> (ø)
#validator 63.68% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 564116e...5a9e146. Read the comment docs.

@CasperWA CasperWA merged commit 6c426df into master Sep 24, 2020
@CasperWA CasperWA deleted the fix_ci branch September 24, 2020 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants