Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #578

Merged
merged 5 commits into from
Oct 31, 2020
Merged

Update dependencies #578

merged 5 commits into from
Oct 31, 2020

Conversation

CasperWA
Copy link
Member

@CasperWA CasperWA commented Oct 30, 2020

This is an extraordinary update of dependencies due to the update of pydantic.

The update of pydantic from v1.6 to v1.7 has incurred changes in the OpenAPI specification. Something that suggests to me we should change the setup.py requirement from ~=MAJOR.MINOR to ~=MAJOR.MINOR.PATCH? (Edit: Done in #547.)

Also, some of the changes in the OpenAPI specification are weird - like the removal of the title for Structure Features? This should be checked and fixed in either the current PR or another one after this has been merged ASAP.

Furthermore, I would suggest to split up the dependabot entry for pip to deal with requirements.txt separately and more often.


Changes in this PR other than the dependabot updates:

  • setup.py has been updated according to the current dependency limitations and updated versions.
  • The pre-commit repos have been updated.
  • OpenAPI specs have been updated according to how pydantic v1.7 produces them.

Edit: All changes related to pydantic v1.7 has been moved to the respective dependabot PR (#576).

@CasperWA CasperWA added the dependency_updates Issues pertaining to updates to our dependencies that are breaking the eager build label Oct 30, 2020
openapi/openapi.json Outdated Show resolved Hide resolved
ml-evs added a commit that referenced this pull request Oct 30, 2020
ml-evs added a commit that referenced this pull request Oct 30, 2020
ml-evs added a commit that referenced this pull request Oct 30, 2020
@CasperWA CasperWA force-pushed the update_deps branch 2 times, most recently from 4f259a9 to 38c8d76 Compare October 30, 2020 16:10
@codecov
Copy link

codecov bot commented Oct 30, 2020

Codecov Report

Merging #578 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #578   +/-   ##
=======================================
  Coverage   91.77%   91.77%           
=======================================
  Files          62       62           
  Lines        3221     3221           
=======================================
  Hits         2956     2956           
  Misses        265      265           
Flag Coverage Δ
project 91.77% <ø> (ø)
validator 64.60% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e51f4c...ad097b4. Read the comment docs.

@CasperWA CasperWA requested a review from ml-evs October 30, 2020 16:15
requirements-dev.txt Outdated Show resolved Hide resolved
@ml-evs ml-evs self-requested a review October 31, 2020 11:26
ml-evs
ml-evs previously approved these changes Oct 31, 2020
Copy link
Member

@ml-evs ml-evs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to bump pre-commit again, but this all seems fine, I'll merge it myself so we don't get any more updates...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependency_updates Issues pertaining to updates to our dependencies that are breaking the eager build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants