Always print summary as last thing in validation #700
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #699.
This minor change ensures the
print_summary()
method is always called beforereturn
ing out of thevalidate_implementation()
method.Two changes were needed:
as_type
"branch".valid
property and printing the summary for the "no base info-branch".I'm not completely sure about the latter change, but it seems to me the
valid
property is used in the printed summary, hence I thought it best to switch these statements around?