Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the optimade container image as a service #107

Merged
merged 4 commits into from
May 16, 2022
Merged

Use the optimade container image as a service #107

merged 4 commits into from
May 16, 2022

Conversation

CasperWA
Copy link
Member

Fixes #106

Instead of running docker-compose in CI.

@CasperWA
Use the optimade container image as a service
af4af34 
Instead of running docker-compose in CI.
@CasperWA
Copy link
Member Author

CasperWA commented May 16, 2022 •
edited
Loading

Hmm, I get the same error locally. It's strange that it prints localhost:5000 instead of gh_actions_host:3213. Is this an error in the validator in OPT?

Or is it perhaps due to the set OPTIMADE_BASE_URL?

@CasperWA
Copy link
Member Author

Or is it perhaps due to the set OPTIMADE_BASE_URL?

Yup - that's it.

@CasperWA CasperWA marked this pull request as ready for review May 16, 2022 15:54
@CasperWA CasperWA requested a review from ml-evs May 16, 2022 15:54
@CasperWA CasperWA enabled auto-merge (squash) May 16, 2022 15:55
ml-evs
ml-evs approved these changes May 16, 2022
View reviewed changes
Copy link
Member

@ml-evs ml-evs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and clean :)

@ml-evs
Copy link
Member

ml-evs commented May 16, 2022

I guess my only comment is actually that the services can be moved to the top-level right to be used by all workflows, I think? Not something to worry about, given auto-merge is about to happen 🙃

@CasperWA CasperWA merged commit 7e620d8 into master May 16, 2022
@CasperWA CasperWA deleted the cwa/fix-106-docker-compose branch May 16, 2022 15:59
@CasperWA
Copy link
Member Author

I guess my only comment is actually that the services can be moved to the top-level right to be used by all workflows, I think? Not something to worry about, given auto-merge is about to happen 🙃

I don't think that's possible. Services are job-specific as far as I know, so this is the main way to do this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ml-evs ml-evs ml-evs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docker-compose references should be removed
2 participants
@CasperWA @ml-evs