Fail run upon error #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CasperWA
force-pushed
the
fix_25_fail-run-upon-error
branch
from
39bf1f9
to
7be3c5b
Compare
|
I have successfully added a CI job that is meant to fail, and only succeeds if it fails. |
|
This PR is currently blocking for other PRs, since the added CI job has been made a requirement for merging into |
This is no longer true, however, upon merging this PR, the branch protection should be updated to include the new CI job. |
|
@ml-evs this is ready for review whenever :) |
ml-evs
approved these changes
Sep 16, 2020
Comment on lines
+137
to
+140
| - name: This runs ONLY if 'Run action' doesn't fail as expected | ||
| if: steps.action.outcome != 'failure' || steps.action.conclusion != 'success' | ||
| run: | | ||
| echo "Outcome: ${{ steps.action.outcome }} (not 'failure'), Conclusion: ${{ steps.action.conclusion }} (not 'success')" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #25
set -ehas been added toentrypoint.sh, so that any non-zero return value will stop the script.Furthermore, an extra test for an invalid version value has been added.