Add create_outputs and results output
#42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new output will be a JSON object of JSON objects. The outer objects' keys represent the base URL, it can either be: - `"unversioned"` - `"vMAJOR"` - `"vMAJOR.MINOR"` - `"vMAJOR.MINOR.PATCH"` where MAJOR, MINOR, and PATCH represent the current OPTIMADE API version. New tests to make sure the `-j/--json` option is used when `create_outputs` is `True`. New CI tests to make sure the output `results` is correctly created, with the correct content depending on the base URLs checked.
CasperWA
force-pushed
the
close_41_json-option
branch
from
7398134
to
cb1dc14
Compare
CasperWA
force-pushed
the
close_41_json-option
branch
from
e3236fc
to
3d2b0af
Compare
CasperWA
force-pushed
the
close_41_json-option
branch
from
dad2600
to
1e511fa
Compare
CasperWA
changed the title
create_outputs and results outputcreate_outputs and results output
|
Edit: All done. |
CasperWA
changed the title
create_outputs and results outputcreate_outputs and results output
Co-authored-by: Matthew Evans <7916000+ml-evs@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #41.
The new output will be a JSON object of JSON objects.
The outer objects' keys represent the base URL, it can either be:
"unversioned""vMAJOR""vMAJOR.MINOR""vMAJOR.MINOR.PATCH"where MAJOR, MINOR, and PATCH represent the current OPTIMADE API version.
New tests to make sure the
-j/--jsonoption is used whencreate_outputsisTrue.New CI tests to make sure the output
resultsis correctly created, with the correct content depending on the base URLs checked.