Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure helper.py script can be called #44

Merged

Conversation

CasperWA
Copy link
Member

Fixes #43

Specify absolute path to helper.py.

@CasperWA CasperWA force-pushed the fix_43_helper-script-in-Docker branch from 47ae2ce to 89c0a3a Compare September 28, 2020 16:33
@CasperWA CasperWA marked this pull request as ready for review September 28, 2020 16:41
@CasperWA
Copy link
Member Author

I tried to create a CI check for this, where it uses itself as if it was an external "user", but this is not possible it seems, due to the timing of how these Docker images are built for the Actions.

Copy link
Member

@ml-evs ml-evs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't look too crazy... 😀

@CasperWA CasperWA merged commit 072fa8d into Materials-Consortia:master Sep 28, 2020
@CasperWA CasperWA deleted the fix_43_helper-script-in-Docker branch September 28, 2020 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python helper.py script not included in Dockerfile
2 participants