Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README #5

Merged
merged 2 commits into from
Mar 12, 2020
Merged

Update README #5

merged 2 commits into from
Mar 12, 2020

Conversation

CasperWA
Copy link
Member

@CasperWA CasperWA commented Mar 11, 2020 •
edited
Loading

Instead of giving each input argument to the action a separate sub-header, list them in a table in the README.md.

For example see here.

Update references to self in example usages.

@CasperWA CasperWA changed the title List inputs in table in README Update README Mar 11, 2020
@CasperWA
Copy link
Member Author

CasperWA commented Mar 12, 2020 •
edited
Loading

Let's wait with this PR until after v1 has been released. Actually, no. Let's update the README also in the v1 update PR ... That's nicer.

@CasperWA CasperWA changed the title Update README [HOLD] Update README Mar 12, 2020
@CasperWA CasperWA requested review from ml-evs and shyamd March 12, 2020 17:28
@CasperWA CasperWA changed the title [HOLD] Update README Update README Mar 12, 2020
@CasperWA CasperWA merged commit 7c255a8 into Materials-Consortia:master Mar 12, 2020
@CasperWA CasperWA deleted the redo_list_of_args_README branch March 12, 2020 17:41
@CasperWA CasperWA mentioned this pull request Mar 12, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ml-evs ml-evs ml-evs approved these changes

@shyamd shyamd shyamd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CasperWA @ml-evs @shyamd