Use MinVer for Nuget Package versioning (#44)

* Add MinVer * Use MinVer to generate correct package versions fixes #42 * Bump fetch v3 * Use correct symbol
MatthiWare · Jul 10, 2022 · 3193495 · 3193495
1 parent 72e51c6
commit 3193495
Show file tree

Hide file tree

Showing 4 changed files with 62 additions and 42 deletions.
diff --git a/.github/workflows/dotnet.yml b/.github/workflows/dotnet.yml
@@ -12,7 +12,9 @@ jobs:
     runs-on: ubuntu-latest
 
     steps:
-    - uses: actions/checkout@v2
+    - uses: actions/checkout@v3
+      with: 
+        fetch-depth: 0
     - name: Setup .NET
       uses: actions/setup-dotnet@v1
       with:

diff --git a/FinancialModelingPrepApi/FinancialModelingPrepApi.csproj b/FinancialModelingPrepApi/FinancialModelingPrepApi.csproj
@@ -1,46 +1,54 @@
-<Project Sdk="Microsoft.NET.Sdk">
+<Project Sdk="Microsoft.NET.Sdk">
 
-  <PropertyGroup>
-    <TargetFramework>net5.0</TargetFramework>
-    <RootNamespace>MatthiWare.FinancialModelingPrep</RootNamespace>
-    <PackageRequireLicenseAcceptance>true</PackageRequireLicenseAcceptance>
-    <GeneratePackageOnBuild>true</GeneratePackageOnBuild>
-    <AssemblyVersion>0.1.12.0</AssemblyVersion>
-    <FileVersion>0.1.12.0</FileVersion>
-    <Company>MatthiWare</Company>
-    <PackageId>MatthiWare.FinancialModelingPrep</PackageId>
-    <Version>0.1.12</Version>
-    <Description>FinancialModelingPrep API Client written in .NET 5</Description>
-    <Copyright>Copyright Matthias Beerens 2021</Copyright>
-    <Product>FinancialModelingPrep API Client</Product>
-    <Authors>Matthias Beerens</Authors>
-    <PackageLicenseFile>LICENSE</PackageLicenseFile>
-    <RepositoryUrl>https://github.com/MatthiWare/FinancialModelingPrep.NET</RepositoryUrl>
-    <RepositoryType>git</RepositoryType>
-    <PackageTags>FinancialModelingPrep stock quote finance-api</PackageTags>
-    <PackageProjectUrl>https://github.com/MatthiWare/FinancialModelingPrep.NET</PackageProjectUrl>
-    <PackageReleaseNotes>
-		- GetEnterpriseValueAsync Type fixed
-	</PackageReleaseNotes>
-    <AssemblyName>FinancialModelingPrep</AssemblyName>
-  </PropertyGroup>
+	<PropertyGroup>
+		<TargetFramework>net5.0</TargetFramework>
+		<RootNamespace>MatthiWare.FinancialModelingPrep</RootNamespace>
+		<PackageRequireLicenseAcceptance>False</PackageRequireLicenseAcceptance>
+		<GeneratePackageOnBuild>True</GeneratePackageOnBuild>
+		<Company>MatthiWare</Company>
+		<PackageId>MatthiWare.FinancialModelingPrep</PackageId>
+		<Description>FinancialModelingPrep API Client written in .NET 5</Description>
+		<Copyright>Copyright Matthias Beerens 2021</Copyright>
+		<Product>FinancialModelingPrep API Client</Product>
+		<Authors>Matthias Beerens</Authors>
+		<PackageLicenseFile>LICENSE</PackageLicenseFile>
+		<RepositoryUrl>https://github.com/MatthiWare/FinancialModelingPrep.NET</RepositoryUrl>
+		<RepositoryType>git</RepositoryType>
+		<PackageTags>FinancialModelingPrep stock quote finance-api</PackageTags>
+		<PackageProjectUrl>https://github.com/MatthiWare/FinancialModelingPrep.NET</PackageProjectUrl>
+		<PackageReleaseNotes>
+			- GetEnterpriseValueAsync Type fixed
+		</PackageReleaseNotes>
+		<AssemblyName>FinancialModelingPrep</AssemblyName>
+	</PropertyGroup>
 
-  <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|AnyCPU'">
-    <DocumentationFile>D:\Source\Repos\FinancialModelingPrep.NET\FinancialModelingPrepApi\FinancialModelingPrepApi.xml</DocumentationFile>
-  </PropertyGroup>
+	<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|AnyCPU'">
+		<DocumentationFile>D:\Source\Repos\FinancialModelingPrep.NET\FinancialModelingPrepApi\FinancialModelingPrepApi.xml</DocumentationFile>
+	</PropertyGroup>
 
-  <ItemGroup>
-    <PackageReference Include="Bert.RateLimiters" Version="1.0.15" />
-    <PackageReference Include="Microsoft.Extensions.DependencyInjection.Abstractions" Version="6.0.0" />
-    <PackageReference Include="Microsoft.Extensions.Http" Version="6.0.0" />
-    <PackageReference Include="Microsoft.Extensions.Logging.Abstractions" Version="6.0.1" />
-  </ItemGroup>
+	<ItemGroup>
+		<PackageReference Include="Bert.RateLimiters" Version="1.0.15" />
+		<PackageReference Include="Microsoft.Extensions.DependencyInjection.Abstractions" Version="6.0.0" />
+		<PackageReference Include="Microsoft.Extensions.Http" Version="6.0.0" />
+		<PackageReference Include="Microsoft.Extensions.Logging.Abstractions" Version="6.0.1" />
+		<PackageReference Include="MinVer" Version="4.1.0">
+			<PrivateAssets>all</PrivateAssets>
+			<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
+		</PackageReference>
+	</ItemGroup>
 
-  <ItemGroup>
-    <None Include="..\LICENSE">
-      <Pack>True</Pack>
-      <PackagePath></PackagePath>
-    </None>
-  </ItemGroup>
+	<PropertyGroup>
+		<MinVerSkip Condition="'$(Configuration)|$(Platform)'=='Debug'">true</MinVerSkip>
+		<MinVerTagPrefix>v</MinVerTagPrefix>
+		<MinVerIgnoreHeight>true</MinVerIgnoreHeight>
+		<MinVerVerbosity>normal</MinVerVerbosity>
+	</PropertyGroup>
+
+	<ItemGroup>
+		<None Include="..\LICENSE">
+			<Pack>True</Pack>
+			<PackagePath></PackagePath>
+		</None>
+	</ItemGroup>
 
 </Project>
diff --git a/FinancialModelingPrepApi/FinancialModelingPrepApi.xml b/FinancialModelingPrepApi/FinancialModelingPrepApi.xml
diff --git a/Tests/CompanyValuation/CompanyValuationTests.cs b/Tests/CompanyValuation/CompanyValuationTests.cs
@@ -302,7 +302,7 @@ public async Task GetCompanyKeyMetricsTTMAsync(string symbol)
         [InlineData("AGS.BR", Period.Annual)]
         [InlineData("CMCSA", Period.Annual)]
         [InlineData("O", Period.Annual)]
-        [InlineData("BRK.B", Period.Annual)]
+        [InlineData("BRK-B", Period.Annual)]
         [InlineData("CX", Period.Annual)]
         public async Task GetCompanyKeyMetricsAsync(string symbol, Period period)
         {