Make timestamp, price nullable (#77)

* Make properties nullable * Fix failing tests * Make avg volume also double * Fix different error handling on FMP
MatthiWare · Jan 20, 2023 · f34af7c · f34af7c
1 parent 1b8f825
commit f34af7c
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 6 deletions.
diff --git a/FinancialModelingPrepApi/Core/Http/FinancialModelingPrepHttpClient.cs b/FinancialModelingPrepApi/Core/Http/FinancialModelingPrepHttpClient.cs
@@ -18,6 +18,7 @@ public class FinancialModelingPrepHttpClient
         private readonly ILogger<FinancialModelingPrepHttpClient> logger;
         private readonly JsonSerializerOptions jsonSerializerOptions;
         private const string EmptyArrayResponse = "[ ]";
+        private const string EmptyArrayResponse2 = "[]";
         private const string ErrorMessageResponse = "Error Message";
 
         public FinancialModelingPrepHttpClient(HttpClient client, FinancialModelingPrepOptions options,
@@ -64,7 +65,8 @@ public async Task<ApiResponse<string>> GetStringAsync(string urlPattern, NameVal
                     return ApiResponse.FromError<string>(errorData.ErrorMessage);
                 }
 
-                if (response.Data.Equals(EmptyArrayResponse, StringComparison.OrdinalIgnoreCase))
+                if (response.Data.Equals(EmptyArrayResponse, StringComparison.OrdinalIgnoreCase) || 
+                    response.Data.Equals(EmptyArrayResponse2, StringComparison.OrdinalIgnoreCase))
                 {
                     return ApiResponse.FromError<string>("Invalid parameters");
                 }

diff --git a/FinancialModelingPrepApi/Model/CompanyValuation/QuoteResponse.cs b/FinancialModelingPrepApi/Model/CompanyValuation/QuoteResponse.cs
@@ -42,10 +42,10 @@ public class QuoteResponse
         public double? PriceAvg200 { get; set; }
 
         [JsonPropertyName("volume")]
-        public long? Volume { get; set; }
+        public double? Volume { get; set; }
 
         [JsonPropertyName("avgVolume")]
-        public long? AvgVolume { get; set; }
+        public double? AvgVolume { get; set; }
 
         [JsonPropertyName("exchange")]
         public string Exchange { get; set; }
@@ -66,9 +66,9 @@ public class QuoteResponse
         public string EarningsAnnouncement { get; set; }
 
         [JsonPropertyName("sharesOutstanding")]
-        public long? SharesOutstanding { get; set; }
+        public double? SharesOutstanding { get; set; }
 
         [JsonPropertyName("timestamp")]
-        public int Timestamp { get; set; }
+        public int? Timestamp { get; set; }
     }
 }
diff --git a/FinancialModelingPrepApi/Model/CompanyValuation/SymbolResponse.cs b/FinancialModelingPrepApi/Model/CompanyValuation/SymbolResponse.cs
@@ -11,7 +11,7 @@ public class SymbolResponse
         public string Name { get; set; }
 
         [JsonPropertyName("price")]
-        public double Price { get; set; }
+        public double? Price { get; set; }
 
         [JsonPropertyName("exchange")]
         public string Exchange { get; set; }