Target both .NET5 and .NET6 #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matthiee
requested changes
Oct 1, 2022
There was a problem hiding this comment.
Hi @tforsberg the PR looks good, however one small change is required to make the CI/CD work again.
Can you update the build script to use .NET 6?
See https://github.com/tforsberg/MatthiWare.FinancialModelingPrep.NET/blob/net6/.github/workflows/dotnet.yml#L19-L21
It probably would be best to use actions/setup-dotnet@v3 and dotnet-version: 6.0.x
After these changes the PR can be merged!
|
Ok, I made the change and committed it to my branch. How do I put this change into the "pull request"? Sorry, I'm fairly new to contributing to other projects. |
…/setup-dotnet@v3"
Matthiee
approved these changes
Oct 1, 2022
|
Hi @tforsberg it seems you already figured it out 😉 just pushing your changes will make them show up here too. PR looks good, thank you for your contribution! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #53
I cloned the repo, updated a couple NuGet packages and Targeted both .NET5 and .NET6