Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding a py.typed file to the package #2

Closed
peteris-zealid opened this issue Jun 29, 2022 · 4 comments · Fixed by #7
Closed

Consider adding a py.typed file to the package #2

peteris-zealid opened this issue Jun 29, 2022 · 4 comments · Fixed by #7

Comments

@peteris-zealid
Copy link
Contributor

Hello,

I ran mypy on the codebase and it revealed only a few minor issues. Nothing that the end user would ever care about. On one hand it might be slightly irresponsible to add a py.typed marker without setting up a type checker to run at each commit, but on the other hand automatically generated stubs will be of much lower quality and should be avoided for practical purposes.

@peteris-zealid
Copy link
Contributor Author

I spoke a bit too soon.

It seems that in crypto_utils.py the type for password in various places should be Optional[bytes] not str.

MatthiasValvekens added a commit that referenced this issue Aug 19, 2022
@MatthiasValvekens
Copy link
Owner

Hi @peteris-zealid,

Sorry, took me a while to get to this one. I added py.typed, fixed all the mypy warnings and added a mypy checker workflow to the repo :). See linked PR.

MatthiasValvekens added a commit that referenced this issue Aug 19, 2022
@peteris-zealid
Copy link
Contributor Author

Hi, I thought this was a closed issue, but thank you for letting me know. Sometimes it pains my heart to see you not getting paid for all the quality work (and support) you are doing on this lib.

@MatthiasValvekens
Copy link
Owner

Well, my GitHub Sponsors registration request finally got processed yesterday, so there's an avenue now... ;)

Not that I have grand expectations about the revenue that would generate, though :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants