Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Android Studio and empty state for views. #3

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

vickychijwani
Copy link

Hi,

This pull request contains 2 changes:

  1. Added support for Android Studio:
    1. Added gradle build script (build.gradle).
    2. Moved all the files from the library/ folder to the root of the repository. Otherwise Android Studio detects the module's name as "library" (because the build.xml / build.gradle is under that folder).
  2. Added support for empty state (ContentState.EMPTY) in views. This is useful in cases where the content varies depending on user actions, for instance when a search returns no results. Also this library doesn't play well with AdapterView#setEmptyView(View), so that can't be used.

Please let me know if further changes are to be made.

    * Useful in cases where the content depends on user actions: when there is no content to show, an empty state notifying the user of the same looks better than a completely blank view.

    * The library doesn't play well with AbsListView#setEmptyView(), so this is a good alternative.
@dallasgutauckis
Copy link
Contributor

Seems like the gradle change was made independently in jhansche/Android-MultiStateView@e19b05f. @jhansche do you think this change will make it in otherwise?

@jhansche
Copy link

@dallasgutauckis the commit was already merged: e19b05f

@jhansche
Copy link

Err, were you asking if this #3 change will get pulled in? It'll need to be merged/rebased since e19b05f was already done before I noticed this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants