Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read configuration for the app directly from the k8s API #3

Merged
merged 1 commit into from
Nov 23, 2023

Conversation

ykulazhenkov
Copy link
Collaborator

This is required to avoid possible issues caused by ConfigMap cache in kubelet.

@adrianchiris
Copy link
Collaborator

what issue ? shouldnt config map update eventually ?

@ykulazhenkov
Copy link
Collaborator Author

what issue ? shouldnt config map update eventually ?

Yeah, eventually, but not immediately. During testing I catch unexpected behavior when I did the following:

  • deployed OFED with safeLoad disabled
  • enabled safeLoad
  • immediately reboot the node
    In this scenario initContainer started with the cached ConfigMap content and safeLoad feature was disabled.

@adrianchiris
Copy link
Collaborator

ack,

being eventually consistent doesnt work well for init containers.

This is required to avoid possible issues caused by
ConfigMap cache in kubelet.

Signed-off-by: Yury Kulazhenkov <ykulazhenkov@nvidia.com>
@adrianchiris adrianchiris merged commit 16ed235 into Mellanox:main Nov 23, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants