Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CRDs are not synced #134

Closed
e0ne opened this issue Mar 9, 2021 · 2 comments · Fixed by #142 or #146
Closed

CRDs are not synced #134

e0ne opened this issue Mar 9, 2021 · 2 comments · Fixed by #142 or #146
Labels
bug Something isn't working

Comments

@e0ne
Copy link
Collaborator

e0ne commented Mar 9, 2021

What happened:
CRDs are not synced in these folders:

What you expected to happen:
CRDs should be the same for helm chart and manual operator deployment. We should sync them and create some CI checkto not introduce this bug in the future.
@e0ne e0ne added the bug Something isn't working label Mar 9, 2021
@moshe010 moshe010 mentioned this issue Mar 12, 2021
Closed
34 tasks
e0ne added a commit to e0ne/network-operator that referenced this issue Mar 15, 2021
@e0ne
Add 'Age' column to CRDs and sync CRDs to helm chart
68c38ad 
Closes: Mellanox#136
Partial-Closes: Mellanox#134
@e0ne e0ne mentioned this issue Mar 15, 2021
Merged
e0ne added a commit to e0ne/network-operator that referenced this issue Mar 15, 2021
@e0ne
Add 'Age' column to CRDs and sync CRDs to helm chart
5335098 
Closes: Mellanox#136
Partial-Closes: Mellanox#134
Signed-off-by: Ivan Kolodiazhnyi <ikolodiazhny@nvidia.com>
@moshe010
Copy link
Collaborator

It seem partial-closes doesn't works in github. I will reopen this

@moshe010 moshe010 reopened this Mar 15, 2021
@e0ne
Copy link
Collaborator Author

e0ne commented Mar 15, 2021

Partial-closed added because there is no automation for this

@e0ne e0ne mentioned this issue Mar 17, 2021
Merged
e0ne added a commit to e0ne/network-operator that referenced this issue Mar 19, 2021
@e0ne
Sync CRDs between operator and helm chart
f3724b7 
CRDs are syncted automatically and CI check is added.

Closes: Mellanox#134
e0ne added a commit to e0ne/network-operator that referenced this issue Mar 19, 2021
@e0ne
Sync CRDs between operator and helm chart
2a8432a 
CRDs are synced automatically and CI check is added.

Closes: Mellanox#134
Signed-off-by: Ivan Kolodiazhnyi <ikolodiazhny@nvidia.com>
@e0ne e0ne mentioned this issue Mar 19, 2021
Merged
e0ne added a commit to e0ne/network-operator that referenced this issue Mar 19, 2021
@e0ne
Sync CRDs between operator and helm chart
f54588f 
CRDs are synced automatically and CI check is added.

Closes: Mellanox#134
Signed-off-by: Ivan Kolodiazhnyi <ikolodiazhny@nvidia.com>
e0ne added a commit to e0ne/network-operator that referenced this issue Mar 19, 2021
@e0ne
Sync CRDs between operator and helm chart
16a3258 
CRDs are synced automatically and CI check is added.

Closes: Mellanox#134
Signed-off-by: Ivan Kolodiazhnyi <ikolodiazhny@nvidia.com>
e0ne added a commit to e0ne/network-operator that referenced this issue Mar 19, 2021
@e0ne
Sync CRDs between operator and helm chart
4bb7d12 
CRDs are synced automatically and CI check is added.

Closes: Mellanox#134
Signed-off-by: Ivan Kolodiazhnyi <ikolodiazhny@nvidia.com>
e0ne added a commit to e0ne/network-operator that referenced this issue Mar 19, 2021
@e0ne
Sync CRDs between operator and helm chart
74ad1eb 
CRDs are synced automatically and CI check is added.

Closes: Mellanox#134
Signed-off-by: Ivan Kolodiazhnyi <ikolodiazhny@nvidia.com>
e0ne added a commit to e0ne/network-operator that referenced this issue Mar 19, 2021
@e0ne
Sync CRDs between operator and helm chart
5c37dec 
CRDs are synced automatically and CI check is added.

Closes: Mellanox#134
Signed-off-by: Ivan Kolodiazhnyi <ikolodiazhny@nvidia.com>
e0ne added a commit to e0ne/network-operator that referenced this issue Mar 19, 2021
@e0ne
Sync CRDs between operator and helm chart
084d658 
CRDs are synced automatically and CI check is added.

Closes: Mellanox#134
Signed-off-by: Ivan Kolodiazhnyi <ikolodiazhny@nvidia.com>
e0ne added a commit to e0ne/network-operator that referenced this issue Mar 19, 2021
@e0ne
Sync CRDs between operator and helm chart
0d3b426 
CRDs are synced automatically and CI check is added.

This patch also updates go.mod and go.sum.

Closes: Mellanox#134
Signed-off-by: Ivan Kolodiazhnyi <ikolodiazhny@nvidia.com>
e0ne added a commit to e0ne/network-operator that referenced this issue Mar 20, 2021
@e0ne
Sync CRDs between operator and helm chart
d9553f6 
CRDs are synced automatically and CI check is added.

This patch also updates go.mod and go.sum.

Closes: Mellanox#134
Signed-off-by: Ivan Kolodiazhnyi <ikolodiazhny@nvidia.com>
e0ne added a commit to e0ne/network-operator that referenced this issue Mar 20, 2021
@e0ne
Sync CRDs between operator and helm chart
231ff5d 
CRDs are synced automatically and CI check is added.

This patch also updates go.mod and go.sum.

Closes: Mellanox#134
Signed-off-by: Ivan Kolodiazhnyi <ikolodiazhny@nvidia.com>
e0ne added a commit to e0ne/network-operator that referenced this issue Mar 20, 2021
@e0ne
Sync CRDs between operator and helm chart
4e3d39c 
CRDs are synced automatically and CI check is added.

This patch also updates go.mod and go.sum.

Closes: Mellanox#134
Signed-off-by: Ivan Kolodiazhnyi <ikolodiazhny@nvidia.com>
e0ne added a commit to e0ne/network-operator that referenced this issue Mar 21, 2021
@e0ne
Sync CRDs between operator and helm chart
46fd070 
CRDs are synced automatically and CI check is added.

This patch also updates go.mod and go.sum.

Closes: Mellanox#134
Signed-off-by: Ivan Kolodiazhnyi <ikolodiazhny@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@e0ne @moshe010