Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support hostDevice secondary network #44

Closed
adrianchiris opened this issue Oct 14, 2020 · 0 comments · Fixed by #126
Closed

Support hostDevice secondary network #44

adrianchiris opened this issue Oct 14, 2020 · 0 comments · Fixed by #126
Labels
enhancement New feature or request

Comments

@adrianchiris
Copy link
Collaborator

Some deployments require multi-network / multi-nics to run RDMA workloads.
e.g applications that require line rate connectivity.

In this case a Pod will require a NIC to be assigned to it.
this is achieved by hostDevice CNI to be used for secondary network.

In this scenario, the Deployment of the operator would need to create per group of NICs:

  1. host device network
  2. device plugin configuration - SRIOV DP can be used here or other- TBD

multus to be used to pass the deviceID to CNI.
@adrianchiris adrianchiris added the enhancement New feature or request label Oct 14, 2020
@e0ne e0ne mentioned this issue Feb 15, 2021
Merged
@moshe010 moshe010 mentioned this issue Mar 3, 2021
Merged
e0ne added a commit to e0ne/network-operator that referenced this issue Mar 12, 2021
@e0ne
Add HostDeviceNetwork basic support
d81d36a 
This patch adds HostDeviceNetwork CRD support and basic
transformation to NetworkAttachmentDefinition to allow
Multus create secondary network.

SR-IOV Network Device Plugin is deployed using Network Operator
Helm chart with default configuration.

NOTE: temporary added "//nolint:dupl" before code will be
refactored.

Closes: Mellanox#44

Signed-off-by: Ivan Kolodiazhnyi <ikolodiazhny@nvidia.com>
e0ne added a commit to e0ne/network-operator that referenced this issue Mar 12, 2021
@e0ne
Add HostDeviceNetwork basic support
4966f48 
This patch adds HostDeviceNetwork CRD support and basic
transformation to NetworkAttachmentDefinition to allow
Multus create secondary network.

SR-IOV Network Device Plugin is deployed using Network Operator
Helm chart with default configuration.

NOTE: temporary added "//nolint:dupl" before code will be
refactored.

Closes: Mellanox#44

Signed-off-by: Ivan Kolodiazhnyi <ikolodiazhny@nvidia.com>
e0ne added a commit to e0ne/network-operator that referenced this issue Mar 12, 2021
@e0ne
Add HostDeviceNetwork basic support
ae437e0 
This patch adds HostDeviceNetwork CRD support and basic
transformation to NetworkAttachmentDefinition to allow
Multus create secondary network.

SR-IOV Network Device Plugin is deployed using Network Operator
Helm chart with default configuration.

NOTE: temporary added "//nolint:dupl" before code will be
refactored.

Closes: Mellanox#44

Signed-off-by: Ivan Kolodiazhnyi <ikolodiazhny@nvidia.com>
e0ne added a commit to e0ne/network-operator that referenced this issue Mar 15, 2021
@e0ne
Add HostDeviceNetwork basic support
09f598a 
This patch adds HostDeviceNetwork CRD support and basic
transformation to NetworkAttachmentDefinition to allow
Multus create secondary network.

SR-IOV Network Device Plugin is deployed using Network Operator
Helm chart with default configuration.

NOTE: temporary added "//nolint:dupl" before code will be
refactored.

Closes: Mellanox#44

Signed-off-by: Ivan Kolodiazhnyi <ikolodiazhny@nvidia.com>
e0ne added a commit to e0ne/network-operator that referenced this issue Mar 15, 2021
@e0ne
Add HostDeviceNetwork basic support
2bd625d 
This patch adds HostDeviceNetwork CRD support and basic
transformation to NetworkAttachmentDefinition to allow
Multus create secondary network.

SR-IOV Network Device Plugin is deployed using Network Operator
Helm chart with default configuration.

NOTE: temporary added "//nolint:dupl" before code will be
refactored.

Closes: Mellanox#44

Signed-off-by: Ivan Kolodiazhnyi <ikolodiazhny@nvidia.com>
e0ne added a commit to e0ne/network-operator that referenced this issue Mar 17, 2021
@e0ne
Add HostDeviceNetwork basic support
e54f427 
This patch adds HostDeviceNetwork CRD support and basic
transformation to NetworkAttachmentDefinition to allow
Multus create secondary network.

SR-IOV Network Device Plugin is deployed using Network Operator
Helm chart with default configuration.

NOTE: temporary added "//nolint:dupl" before code will be
refactored.

Closes: Mellanox#44

Signed-off-by: Ivan Kolodiazhnyi <ikolodiazhny@nvidia.com>
e0ne added a commit to e0ne/network-operator that referenced this issue Mar 17, 2021
@e0ne
Add HostDeviceNetwork basic support
993c18e 
This patch adds HostDeviceNetwork CRD support and basic
transformation to NetworkAttachmentDefinition to allow
Multus create secondary network.

SR-IOV Network Device Plugin is deployed using Network Operator
Helm chart with default configuration.

NOTE: temporary added "//nolint:dupl" before code will be
refactored.

Closes: Mellanox#44

Signed-off-by: Ivan Kolodiazhnyi <ikolodiazhny@nvidia.com>
e0ne added a commit to e0ne/network-operator that referenced this issue Mar 21, 2021
@e0ne
Add HostDeviceNetwork basic support
b8b943f 
This patch adds HostDeviceNetwork CRD support and basic
transformation to NetworkAttachmentDefinition to allow
Multus create secondary network.

SR-IOV Network Device Plugin is deployed using Network Operator
Helm chart with default configuration.

NOTE: temporary added "//nolint:dupl" before code will be
refactored.

Closes: Mellanox#44

Signed-off-by: Ivan Kolodiazhnyi <ikolodiazhny@nvidia.com>
e0ne added a commit to e0ne/network-operator that referenced this issue Mar 27, 2021
@e0ne
Add HostDeviceNetwork basic support
67ac036 
This patch adds HostDeviceNetwork CRD support and basic
transformation to NetworkAttachmentDefinition to allow
Multus create secondary network.

SR-IOV Network Device Plugin is deployed using Network Operator
Helm chart with default configuration.

This patch also optimize NetworkAttachmentDef link generation
both for MacvlanNetwork and HostDeviceNetwork CRs.

We should add link for NetworkAttachmentDef only if
MacvlanNetwork or HostDeviceNetwork CR is in a 'Ready' state.
It allows us to make less Kubernetes API calls.

NOTE: temporary added "//nolint:dupl" before code will be
refactored.

Closes: Mellanox#44

Signed-off-by: Ivan Kolodiazhnyi <ikolodiazhny@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add HostDeviceNetwork basic support e0ne/network-operator
1 participant
@adrianchiris