Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: ensure that we don't panic on DP validations #1073

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

vasrem
Copy link
Contributor

@vasrem vasrem commented Sep 18, 2024

Before, if a user wouldn't specify config for any of the rdma shared DP or sriov DP, the process would panic. This is now fixed.

Also, split a function into 2 to pass the linter.

@vasrem vasrem requested review from almaslennikov, rollandf and ykulazhenkov and removed request for rollandf September 18, 2024 10:52
@coveralls
Copy link
Collaborator

coveralls commented Sep 18, 2024

Pull Request Test Coverage Report for Build 10920979116

Details

  • 37 of 43 (86.05%) changed or added relevant lines in 1 file are covered.
  • 17 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.4%) to 60.537%

Changes Missing Coverage Covered Lines Changed/Added Lines %
api/v1alpha1/validator/nicclusterpolicy_webhook.go 37 43 86.05%
Files with Coverage Reduction New Missed Lines %
pkg/state/state_hostdevice_network.go 2 78.38%
controllers/hostdevicenetwork_controller.go 2 89.77%
pkg/state/state_skel.go 4 83.63%
controllers/nicclusterpolicy_controller.go 9 75.31%
Totals Coverage Status
Change from base Build 10916956528: 0.4%
Covered Lines: 3335
Relevant Lines: 5509

💛 - Coveralls

@vasrem vasrem force-pushed the bugfix/ensure-config-is-checked branch from fb28a94 to c99cde2 Compare September 18, 2024 11:12
Signed-off-by: Vasilis Remmas <vremmas@nvidia.com>
@vasrem vasrem force-pushed the bugfix/ensure-config-is-checked branch from c99cde2 to aa73e86 Compare September 18, 2024 11:13
Copy link
Collaborator

@almaslennikov almaslennikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once CI passes

@vasrem
Copy link
Contributor Author

vasrem commented Sep 18, 2024

/retest-image_scan

@rollandf rollandf merged commit 19a00c9 into Mellanox:master Sep 18, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants