Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cniSpec to HostDeviceRenderData and prettyPrint CNI JSON #570

Closed
wants to merge 1 commit into from

Conversation

tariq1890
Copy link
Contributor

Add cniSpec as a renderable object to HostDeviceRenderData and use go template to prettyPrint the cniSpec json

If this change looks okay, I can make this apply to all the other Net-Attach-Def renderers and update test cases

@adrianchiris @e0ne

@tariq1890 tariq1890 force-pushed the host-device-cni-format branch 4 times, most recently from b417d6f to 90ae6b0 Compare July 11, 2023 06:58
@adrianchiris
Copy link
Collaborator

@e0ne @rollandf can you take a look on this one ?

@rollandf
Copy link
Member

/retest-nic_operator_helm

@rollandf
Copy link
Member

/retest-nic_operator_kind

Copy link
Member

@rollandf rollandf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Do you have an example of the output before and after the change?

@rollandf
Copy link
Member

Test for hostdevice fails:

10:35:10 TASK [projects/nic-operator-kind/test : Print tests results] *******************
10:35:10 task path: /jenkins/workspace/nic_operator_kind-ci/ansible/roles/projects/nic-operator-kind/test/tasks/main.yml:108
10:35:10 ok: [localhost] => {
10:35:10     "tests_results": {
10:35:10         "test-ofed-and-hostdevice-ib": "Failed",
10:35:10         "test-ofed-and-rdma": "Passed",
10:35:10         "test-rdma-only": "Passed"
10:35:10     }
10:35:10 }
10:35:10 
10:35:10 PLAY RECAP *********************************************************************
10:35:10 localhost                  : ok=283  changed=97   unreachable=0    failed=1    skipped=29   rescued=0    ignored=0 

@@ -38,6 +38,8 @@ import (
)

const (
stateHostDeviceCNIVersion = "v0.3.1"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rollandf I think this is why the e2e tests fail. I should be specifying cniVersion as 0.3.1 instead of v0.3.1

Signed-off-by: Tariq Ibrahim <tibrahim@nvidia.com>
@tariq1890
Copy link
Contributor Author

Closing this PR as it doesn't perform the required formatting

@tariq1890 tariq1890 closed this Aug 2, 2023
@tariq1890 tariq1890 deleted the host-device-cni-format branch August 2, 2023 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants