-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add cniSpec to HostDeviceRenderData and prettyPrint CNI JSON #570
Conversation
b417d6f
to
90ae6b0
Compare
/retest-nic_operator_helm |
/retest-nic_operator_kind |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Do you have an example of the output before and after the change?
Test for hostdevice fails:
|
90ae6b0
to
357a298
Compare
@@ -38,6 +38,8 @@ import ( | |||
) | |||
|
|||
const ( | |||
stateHostDeviceCNIVersion = "v0.3.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rollandf I think this is why the e2e tests fail. I should be specifying cniVersion as 0.3.1
instead of v0.3.1
357a298
to
ae74e2a
Compare
Signed-off-by: Tariq Ibrahim <tibrahim@nvidia.com>
ae74e2a
to
45fb85f
Compare
Closing this PR as it doesn't perform the required formatting |
Add cniSpec as a renderable object to
HostDeviceRenderData
and use go template to prettyPrint the cniSpec jsonIf this change looks okay, I can make this apply to all the other Net-Attach-Def renderers and update test cases
@adrianchiris @e0ne