-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update operator-sdk to 1.3.0 #86
Conversation
f01dcec
to
28828bc
Compare
/retest-all |
16b8988
to
44ce70a
Compare
Can you rebase your PR so conflicts are resolved ? Generally it seems ok however a few issues i encountered;
also a general question: |
udated
not duplicated but auto-generated, as discussed it will be removed in a new commit and update the example
it will be updated in new commit
The issue is related to the new test in
yes
yes |
6a175f4
to
3401738
Compare
- Move pkg/api and pkg/controller and cmd/manager/main.go to project root and update them according to new sdk structure - Update Makefile with new rules - Move build/Dockerfile project root - Add new auto generated config dir Signed-off-by: Mamduh Alassi <mamduhala@mellanox.com>
@Mmduh-483 i see nic_operator CI is failing |
@AbdYsn need to adjust the new updates since this PR replace the template in |
So i have reviewed this
|
In Mellanox/network-operator#86, the network operator updates the operator SDK to v1.3, which break the CI. This patch fixes the break in the CI and support the new and old ways of deploying the operator.
In Mellanox/network-operator#86, the network operator updates the operator SDK to v1.3, which break the CI. This patch fixes the break in the CI and support the new and old ways of deploying the operator.
In Mellanox/network-operator#86, the network operator updates the operator SDK to v1.3, which break the CI. This patch fixes the break in the CI and support the new and old ways of deploying the operator.
- Move move example/delete-operator.sh example/deploy-operator.sh to scripts/ - Read CRDs from config/crd/bases - Update README Signed-off-by: Mamduh Alassi <mamduhala@mellanox.com>
Signed-off-by: Mamduh Alassi <mamduhala@mellanox.com>
@adrianchiris Updated the PR except for 2, |
/retest-nic_operator |
Fixes #33