Skip to content
This repository has been archived by the owner on Nov 9, 2023. It is now read-only.

Retract v1.0.1 (#18) #19

Merged
merged 1 commit into from
Jul 25, 2023
+1 −1
Merged

Retract v1.0.1 (#18) #19

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

## [1.0.1]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be better to mark it as (RETRACTED) or similar, rather than removing - if there's something acceptable that will pass changelog lint

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually we do something like

## [1.0.1] - [DEPRECATED]

Copy link
Contributor

@mcmire mcmire Jul 25, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be better to mark it as (RETRACTED) or similar, rather than removing - if there's something acceptable that will pass changelog lint

Yeah, absolutely — even if we are retracting a version, we still ought to keep it in the changelog for posterity. I believe that auto-changelog should be okay with any text added after a version number. We have a precedent for adding a [DEPRECATED] tag here: https://github.com/MetaMask/eth-sig-util/blob/main/CHANGELOG.md#500-deprecated (EDIT: Mark got there first 😅 )

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main reason we leave these releases in the changelog is that npm provides no way to pull them in most cases. We can't retract it from npm even if we wanted to, but we can mark it as deprecated.

## [1.0.1] [RETRACTED]
### Changed
- Updated dependencies: ([#16](https://github.com/MetaMask/eth-json-rpc-provider/pull/16))
- Switched json-rpc-engine@^6.1.0 -> @metamask/json-rpc-engine@^7.0.0
Expand Down