Add salt to the EIP-712 domain type
#176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gudahtt
force-pushed
the
add-eip-712-domain-salt
branch
from
059d440
to
4be2e43
Compare
|
|
Gudahtt
force-pushed
the
add-eip-712-hash-tests
branch
2 times, most recently
from
b9402a2
to
030b96b
Compare
Gudahtt
force-pushed
the
add-eip-712-domain-salt
branch
from
4be2e43
to
f5100a2
Compare
The type for the `domain` property of an EIP-712 typed message has been updated to include `salt`, which is in the EIP-712 specification [1]. The tests have been updated to include this property. This is an optional property, so this is a non-breaking change. [1]: https://eips.ethereum.org/EIPS/eip-712#definition-of-encodedata
Gudahtt
force-pushed
the
add-eip-712-domain-salt
branch
from
f5100a2
to
1abdcac
Compare
Gudahtt
commented
Aug 16, 2021
| @@ -47,6 +47,7 @@ export interface TypedMessage<T extends MessageTypes> { | |||
| version?: string; | |||
| chainId?: number; | |||
| verifyingContract?: string; | |||
| salt?: ArrayBuffer; | |||
There was a problem hiding this comment.
I chose ArrayBuffer for the expected type because it seemed like the most reasonable way to communicate raw bytes, since it's the underlying data structure for typed arrays. This is the only cross-platform way to represent bytes I think 🤔.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The type for the
domainproperty of an EIP-712 typed message has been updated to includesalt, which is in the EIP-712 specification.The tests have been updated to include this property.
This is an optional property, so this is a non-breaking change.