Add validation to check that parameters aren't nullish #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gudahtt
force-pushed
the
add-parameter-nullish-validation
branch
from
b76614b
to
bc22483
Compare
|
Further validation was intentionally delayed until later because that gets awfully complicated if we're also trying to avoid breaking changes. There are a lot of "invalid" parameters that will still produce valid signatures. |
Gudahtt
force-pushed
the
add-parameter-nullish-validation
branch
from
bc22483
to
e516215
Compare
Validation has been added to the signing and encryption functions to ensure that the parameters are not nullish. This should help with migrating from the last major version, as it would be easy to accidentally use the wrong parameter name when migrating. A nullish check was used rather than a falsy check because there are falsy values that are valid for some parameters (e.g. the data being signed can be `0`). `null` and `undefined` are never valid in these cases though.
Gudahtt
force-pushed
the
add-parameter-nullish-validation
branch
from
e516215
to
d7902a5
Compare
shanejonas
approved these changes
Sep 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validation has been added to the signing and encryption functions to ensure that the parameters are not nullish. This should help with migrating from the last major version, as it would be easy to accidentally use the wrong parameter name when migrating.
A nullish check was used rather than a falsy check because there are falsy values that are valid for some parameters (e.g. the data being signed can be
0).nullandundefinedare never valid in these cases though.