Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5.1.0 #312

Merged
merged 5 commits into from
May 1, 2023
Merged

5.1.0 #312

merged 5 commits into from
May 1, 2023

Conversation

github-actions[bot]
Copy link
Contributor

This is the release candidate for version 5.1.0.

github-actions and others added 2 commits April 28, 2023 23:04
@legobeat legobeat marked this pull request as ready for review April 28, 2023 23:08
@legobeat legobeat requested a review from a team as a code owner April 28, 2023 23:09
Gudahtt
Gudahtt previously approved these changes Apr 28, 2023
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

CHANGELOG.md Outdated
## [5.1.0]
### Changed
- deps: bn.js@4.11.8->4.12.0 ([#309](https://github.com/MetaMask/eth-sig-util/pull/309))
- Type specification; minor input validation fixes; TypeScript 4.8 ([#307](https://github.com/MetaMask/eth-sig-util/pull/307))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: It would be great to explain in more detail what these input validation fixes are

We can split this into separate entries as well if it's easier to read that way. The TypeScript update might be more easily read as a separate entry for example

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated!

@legobeat legobeat merged commit fb40290 into main May 1, 2023
@legobeat legobeat deleted the release/5.1.0 branch May 1, 2023 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants