Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Typed Signatures with 0x value fails to recover Snaps Accounts #22099

Closed
seaona opened this issue Nov 30, 2023 · 2 comments
Closed

[Bug]: Typed Signatures with 0x value fails to recover Snaps Accounts #22099

seaona opened this issue Nov 30, 2023 · 2 comments
Assignees
@gantunesr @danroc
Labels
high-priority Sev1-high High severity; partial loss of service with severe impact upon users, with no workaround. team-accounts type-bug

Comments

@seaona
Copy link
Contributor

seaona commented Nov 30, 2023 •
edited
Loading

Describe the bug

Problem: in the process of updating the test-dapp version module, for testing signatures with 0x values, I've seen that Snap Accounts fail to recover their address on those type of signatures.

Context: https://github.com/MetaMask/test-dapp/pull/274/files

Expected behavior

No response

Screenshots/Recordings

snaps-account-signature.mp4

Steps to reproduce

  1. Add a Snap Account
  2. Go to the test dapp
  3. Trigger a Signature Typed 4
  4. Try to recover the address -- see console error

Error messages or log output

No response

Version

11.6.0 (probably earlier too)

Build type

None

Browser

Chrome

Operating system

Linux

Hardware wallet

No response

Additional context

No response

Severity

No response
@plasmacorral
Copy link
Contributor

Related https://github.com/MetaMask/accounts-planning/issues/166

@Nick-Son Nick-Son added team-snaps DEPRECATED: Use "team-snaps-platform" or "team-snaps-ecosystem" instead Sev3-low Low severity; minimal to no impact upon users labels Dec 1, 2023
@AlexJupiter AlexJupiter added Sev1-high High severity; partial loss of service with severe impact upon users, with no workaround. high-priority team-accounts and removed Sev3-low Low severity; minimal to no impact upon users area-snaps team-snaps DEPRECATED: Use "team-snaps-platform" or "team-snaps-ecosystem" instead labels Dec 11, 2023
@plasmacorral
Copy link
Contributor

Resolved with changes in Snap Simple Keyring v 1.1.1, tested with extension 11.7.2 in chrome.

https://recordit.co/hqGAaJzrXA

@benjisclowder benjisclowder mentioned this issue Jan 29, 2024
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gantunesr gantunesr

@danroc danroc

Labels
high-priority Sev1-high High severity; partial loss of service with severe impact upon users, with no workaround. team-accounts type-bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@AlexJupiter @Nick-Son @gantunesr @plasmacorral @seaona @danroc