Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update eth-sig-util to fix a regression #131

Merged
merged 1 commit into from
Dec 12, 2023
Merged

fix: update eth-sig-util to fix a regression #131

merged 1 commit into from
Dec 12, 2023

Conversation

danroc
Copy link
Contributor

@danroc danroc commented Dec 12, 2023 •
edited
Loading

Description

A regression was introduced on eth-sig-util 6.0.1 and 7.0.0, see: MetaMask/eth-sig-util#340.

This PR bumps this dependency to 7.0.1 which contains the fix.

Testing steps

  1. Go to https://metamask.github.io/test-dapp/
  2. Connect to an account managed by the SSK
  3. Go to Sign Typed Data V4 and click on Sign
  4. Click on Verify
  5. The signature should be sucessfully verified

@danroc
fix: update eth-sig-util to fix a regression
b5beac6 
A regression was introduced on eth-sig-util 6.0.1 and 7.0.0, see:
MetaMask/eth-sig-util#340
@danroc danroc requested a review from a team as a code owner December 12, 2023 17:00
@socket-security Socket Security
Copy link

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@metamask/eth-sig-util 7.0.0...7.0.1 None +0/-2 134 kB metamaskbot

k-g-j
k-g-j approved these changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@k-g-j k-g-j left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and works as expected!

Screenshot 2023-12-12 at 4 33 33 PM

@danroc danroc merged commit 441ea87 into main Dec 12, 2023
14 checks passed
@danroc danroc deleted the fix/update-eth-sig-util branch December 12, 2023 21:38
@plasmacorral plasmacorral mentioned this pull request Jan 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gantunesr gantunesr gantunesr approved these changes

@k-g-j k-g-j k-g-j approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danroc @gantunesr @k-g-j