Fix "Navigation Signature - Different signature types ini..." flaky tests #26507
Assignees
Labels
flaky tests
release-12.4.0
Issue or pull request that will be included in release 12.4.0
Sev2-normal
Normal severity; minor loss of service or inconvenience.
team-extension-platform
type-bug
Comments
hjetpoluru
added
type-bug
Sev2-normal
seaona
added
area-qa
7 tasks
seaona
added a commit
that referenced
this issue
Aug 29, 2024
…tiates and queues multiple signatures and confirms` (#26707) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** There is a known race-condition that can display the signature queue in unexpected order, so the test had a delay to address that, but this doesn't fix the issue in all occasions. In this PR we add a deterministic condition, to ensure this doesn't happen: we wait until we find an element for the given signature, before triggering a new one, making sure signatures are ordered. [](https://codespaces.new/MetaMask/metamask-extension/pull/26707?quickstart=1) ## **Related issues** Fixes: #26507 ## **Manual testing steps** 1. Check ci ## **Screenshots/Recordings** The artifacts and local run show how sometimes we start with the signature page 2, instead of the1, making the subsequent steps to fail.  ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
](https://codespaces.new/MetaMask/metamask-extension/pull/26707?quickstart=1){kind=link}
metamaskbot
added
the
release-12.5.0
gauthierpetetin
added
release-12.4.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/96085/workflows/9bfb78e1-6664-470c-909f-9e727ba0c086/jobs/3577079/tests
The text was updated successfully, but these errors were encountered: