fix: node being setup twice #26052

itsyoboieltr · 2024-07-23T15:57:23Z

Description

This PR uses the setup-environment workflow to reduce duplicated code and optimize performance for cases where Node.js was being setup twice during a workflow.

Related issues

Fixes: #25683

Manual testing steps

CI should pass

Screenshots/Recordings

Not applicable

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

…ode-twice

github-actions · 2024-07-23T15:57:36Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

greptile-apps

PR Summary

This PR optimizes the CI workflow by ensuring Node.js is only set up once, reducing redundancy and improving performance.

Updated package.json to rename script add-team-label-to-pr to add-team-label for consistency.
Modified .github/workflows/add-team-label.yml to use the new script name.
Updated .github/workflows/check-pr-labels.yml to utilize the setup-environment composite action.
Adjusted .github/workflows/add-release-label.yml to include the setup-environment action.
Revised .github/workflows/fitness-functions.yml to incorporate the setup-environment action.

_{1 file(s) reviewed, no comment(s)}
_{Edit PR Review Bot Settings}

greptile-apps

PR Summary

(updates since last review)

This PR optimizes the CI workflow by ensuring Node.js is only set up once, reducing redundancy and improving performance.

Removed test-e2e-swap-playwright job from .circleci/config.yml to streamline the CI process.
Trimmed output of git diff command in .circleci/scripts/git-diff-develop.ts for cleaner diff files.
Updated German localization in app/_locales/de/messages.json by removing sendAToken message.
Enhanced initialization process in app/scripts/background.js for better test environment setup.
Added new migration scripts 120.1.ts and 122.ts to handle state updates and feature flags.

_{146 file(s) reviewed, no comment(s)}
_{Edit PR Review Bot Settings}

greptile-apps

PR Summary

(updates since last review)

This PR optimizes the CI workflow by ensuring Node.js is only set up once, reducing redundancy and improving performance.

Modified test/e2e/vault-decryption-chrome.spec.js to improve test reliability by adding disableServerMochaToBackground and refining window handle management.
Replaced Typography with Text component in ui/pages/onboarding-flow/creation-successful/creation-successful.js for design consistency.
Updated multiple GitHub workflows to use the setup-environment composite action, eliminating redundant Node.js setups.

_{2 file(s) reviewed, no comment(s)}
_{Edit PR Review Bot Settings}

metamaskbot · 2024-07-25T14:32:48Z

Builds ready [945f9e4]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (305 ± 289 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	70	459	146	100	48
		domContentLoaded	9	190	48	45	22
		load	43	2430	305	601	289
		domInteractive	9	190	47	45	22

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

codecov · 2024-07-25T14:33:47Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.94%. Comparing base (51410b2) to head (096df6e).
Report is 15 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop   #26052   +/-   ##
========================================
  Coverage    69.94%   69.94%           
========================================
  Files         1409     1409           
  Lines        49795    49795           
  Branches     13773    13773           
========================================
  Hits         34826    34826           
  Misses       14969    14969

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

greptile-apps

PR Summary

(updates since last review)

This PR optimizes the CI workflow by ensuring Node.js is only set up once, reducing redundancy and improving performance.

Added test/e2e/tests/confirmations/alerts/queued-confirmations.spec.ts to test queued confirmation alerts.
Introduced ui/pages/confirmations/hooks/alerts/transactions/useQueuedConfirmationsAlerts.ts for handling queued confirmation alerts.
Updated ui/pages/confirmations/components/confirm-page-container/confirm-page-container-content/confirm-page-container-content.component.test.js to include new error handling scenarios.
Modified ui/pages/confirmations/confirm-transaction-base/confirm-transaction-base.test.js to enhance test coverage for transaction confirmations.
Added ui/pages/confirmations/confirmation/components/queued-requests-banner-alert/queued-requests-banner-alert.tsx to display alerts for queued requests.

_{95 file(s) reviewed, no comment(s)}
_{Edit PR Review Bot Settings}

sonarcloud · 2024-07-25T15:23:29Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

metamaskbot · 2024-07-25T15:50:17Z

Builds ready [096df6e]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (202 ± 266 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	81	481	124	84	40
		domContentLoaded	11	99	32	23	11
		load	49	2619	202	555	266
		domInteractive	11	99	32	23	11

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

DDDDDanica · 2024-07-25T16:06:41Z

lgtm !

itsyoboieltr added 11 commits July 12, 2024 17:06

fix: test setup environment

9d77252

feat: add-team-label reusable workflow

fea42c4

Merge branch 'develop' into make-add-team-label-reusable-workflow

1540b2e

Merge branch 'develop' into make-add-team-label-reusable-workflow

b3521d1

Merge branch 'develop' into make-add-team-label-reusable-workflow

2082de3

fix: reusable workflow paths

2f7b008

Update add-team-label.yml

80af2eb

Update add-team-label.yml

da0a951

Merge branch 'develop' into make-add-team-label-reusable-workflow

4ed5b8a

Merge branch 'make-add-team-label-reusable-workflow' into fix-setup-n…

a98e319

…ode-twice

feat: use setup environment

0579357

itsyoboieltr self-assigned this Jul 23, 2024

itsyoboieltr requested a review from a team as a code owner July 23, 2024 15:57

greptile-apps bot reviewed Jul 23, 2024

View reviewed changes

metamaskbot added the team-extension-platform label Jul 23, 2024

Merge branch 'develop' into fix-setup-node-twice

42ce663

greptile-apps bot reviewed Jul 24, 2024

View reviewed changes

Merge branch 'develop' into fix-setup-node-twice

4b24304

greptile-apps bot reviewed Jul 24, 2024

View reviewed changes

Merge branch 'develop' into fix-setup-node-twice

945f9e4

greptile-apps bot reviewed Jul 25, 2024

View reviewed changes

Merge branch 'develop' into fix-setup-node-twice

096df6e

itsyoboieltr requested review from Gudahtt, danjm and DDDDDanica July 25, 2024 15:37

DDDDDanica approved these changes Jul 25, 2024

View reviewed changes

hjetpoluru requested review from HowardBraham and legobeat July 26, 2024 18:02

danjm approved these changes Jul 29, 2024

View reviewed changes

itsyoboieltr merged commit cb3bcee into develop Jul 29, 2024
76 checks passed

itsyoboieltr deleted the fix-setup-node-twice branch July 29, 2024 15:39

github-actions bot locked and limited conversation to collaborators Jul 29, 2024

metamaskbot added the release-12.4.0 Issue or pull request that will be included in release 12.4.0 label Jul 29, 2024

gauthierpetetin added release-12.3.0 Issue or pull request that will be included in release 12.3.0 and removed release-12.4.0 Issue or pull request that will be included in release 12.4.0 labels Sep 11, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: node being setup twice #26052

fix: node being setup twice #26052

itsyoboieltr commented Jul 23, 2024 •

edited by github-actions bot

Loading

github-actions bot commented Jul 23, 2024

greptile-apps bot left a comment

greptile-apps bot left a comment

greptile-apps bot left a comment

metamaskbot commented Jul 25, 2024

codecov bot commented Jul 25, 2024 •

edited

Loading

greptile-apps bot left a comment

sonarcloud bot commented Jul 25, 2024

metamaskbot commented Jul 25, 2024

DDDDDanica commented Jul 25, 2024

fix: node being setup twice #26052

fix: node being setup twice #26052

Conversation

itsyoboieltr commented Jul 23, 2024 • edited by github-actions bot Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Jul 23, 2024

greptile-apps bot left a comment

Choose a reason for hiding this comment

PR Summary

greptile-apps bot left a comment

Choose a reason for hiding this comment

PR Summary

greptile-apps bot left a comment

Choose a reason for hiding this comment

PR Summary

metamaskbot commented Jul 25, 2024

codecov bot commented Jul 25, 2024 • edited Loading

Codecov Report

greptile-apps bot left a comment

Choose a reason for hiding this comment

PR Summary

sonarcloud bot commented Jul 25, 2024

Quality Gate passed

metamaskbot commented Jul 25, 2024

DDDDDanica commented Jul 25, 2024

itsyoboieltr commented Jul 23, 2024 •

edited by github-actions bot

Loading

codecov bot commented Jul 25, 2024 •

edited

Loading