fix: Flaky test `4byte setting` #26111

hjetpoluru · 2024-07-25T01:59:07Z

Description

This PR fixes a flaky test for the MMI build where clicking on the Settings menu option was problematic.
I've added a conditional check to wait for the 'Portfolio Dashboard' to load if the build is MMI.

Related issues

Fixes:
#26110

Manual testing steps

Execute below commands local or in codespaces run in chrome the browser
yarn
yarn build:test:mmi
yarn test:e2e:single test/e2e/tests/settings/4byte-directory.spec.js --browser=chrome

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-07-25T01:59:21Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

… fix-flaky-test-4byte

metamaskbot · 2024-07-25T03:23:39Z

Builds ready [4d49b49]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (67 ± 8 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	62	126	95	18	8
		domContentLoaded	9	65	31	18	8
		load	38	99	67	18	8
		domInteractive	9	65	31	18	8

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

… fix-flaky-test-4byte

codecov · 2024-07-25T15:06:55Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.94%. Comparing base (b27dd2b) to head (3872f1e).

Additional details and impacted files

@@           Coverage Diff            @@
##           develop   #26111   +/-   ##
========================================
  Coverage    69.94%   69.94%           
========================================
  Files         1409     1409           
  Lines        49794    49794           
  Branches     13773    13773           
========================================
  Hits         34826    34826           
  Misses       14968    14968

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

metamaskbot · 2024-07-25T15:16:58Z

Builds ready [80004b2]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (240 ± 249 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	69	293	106	47	22
		domContentLoaded	9	86	29	22	11
		load	45	1800	240	519	249
		domInteractive	9	86	29	22	11

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

… fix-flaky-test-4byte

metamaskbot · 2024-07-25T17:08:10Z

Builds ready [c7a77bf]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (164 ± 189 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	73	142	106	17	8
		domContentLoaded	12	55	27	12	6
		load	53	1882	164	394	189
		domInteractive	12	55	27	12	6

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

… fix-flaky-test-4byte

sonarcloud · 2024-07-26T01:43:40Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

metamaskbot · 2024-07-26T02:14:28Z

Builds ready [3872f1e]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (211 ± 219 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	62	187	95	30	14
		domContentLoaded	9	53	20	11	6
		load	40	1635	211	457	219
		domInteractive	9	53	20	11	6

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

chloeYue

LGTM !

Added conditional check for mmi and wait for portfolio

0a01b00

hjetpoluru added team-extension-platform flaky tests labels Jul 25, 2024

hjetpoluru self-assigned this Jul 25, 2024

metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Jul 25, 2024

Merge branch 'develop' of github.com:MetaMask/metamask-extension into…

4d49b49

… fix-flaky-test-4byte

hjetpoluru requested review from vthomas13, chloeYue and seaona July 25, 2024 14:44

hjetpoluru marked this pull request as ready for review July 25, 2024 14:45

hjetpoluru requested a review from a team as a code owner July 25, 2024 14:45

Merge branch 'develop' of github.com:MetaMask/metamask-extension into…

80004b2

… fix-flaky-test-4byte

chloeYue previously approved these changes Jul 25, 2024

View reviewed changes

hjetpoluru added 2 commits July 25, 2024 12:23

Merge branch 'develop' of github.com:MetaMask/metamask-extension into…

d4dc069

… fix-flaky-test-4byte

Replaced with openMenuSafe

c7a77bf

hjetpoluru dismissed chloeYue’s stale review via c7a77bf July 25, 2024 16:33

hjetpoluru requested a review from chloeYue July 25, 2024 16:33

Merge branch 'develop' of github.com:MetaMask/metamask-extension into…

3872f1e

… fix-flaky-test-4byte

chloeYue approved these changes Jul 26, 2024

View reviewed changes

danjm approved these changes Jul 26, 2024

View reviewed changes

vthomas13 approved these changes Jul 26, 2024

View reviewed changes

hjetpoluru merged commit f4f008a into develop Jul 26, 2024
76 checks passed

hjetpoluru deleted the fix-flaky-test-4byte branch July 26, 2024 14:57

github-actions bot locked and limited conversation to collaborators Jul 26, 2024

metamaskbot added the release-12.4.0 Issue or pull request that will be included in release 12.4.0 label Jul 26, 2024

gauthierpetetin added release-12.3.0 Issue or pull request that will be included in release 12.3.0 and removed release-12.4.0 Issue or pull request that will be included in release 12.4.0 labels Sep 11, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Flaky test `4byte setting` #26111

fix: Flaky test `4byte setting` #26111

hjetpoluru commented Jul 25, 2024 •

edited

Loading

github-actions bot commented Jul 25, 2024

metamaskbot commented Jul 25, 2024

codecov bot commented Jul 25, 2024 •

edited

Loading

metamaskbot commented Jul 25, 2024

metamaskbot commented Jul 25, 2024

sonarcloud bot commented Jul 26, 2024

metamaskbot commented Jul 26, 2024

chloeYue left a comment

fix: Flaky test 4byte setting #26111

fix: Flaky test 4byte setting #26111

Conversation

hjetpoluru commented Jul 25, 2024 • edited Loading

Description

Related issues

Manual testing steps

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Jul 25, 2024

metamaskbot commented Jul 25, 2024

codecov bot commented Jul 25, 2024 • edited Loading

Codecov Report

metamaskbot commented Jul 25, 2024

metamaskbot commented Jul 25, 2024

sonarcloud bot commented Jul 26, 2024

Quality Gate passed

metamaskbot commented Jul 26, 2024

chloeYue left a comment

Choose a reason for hiding this comment

fix: Flaky test `4byte setting` #26111

fix: Flaky test `4byte setting` #26111

hjetpoluru commented Jul 25, 2024 •

edited

Loading

codecov bot commented Jul 25, 2024 •

edited

Loading