Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrating interactive-replacement-token-page to ts #26115

Merged

Conversation

albertolive
Copy link
Contributor

@albertolive albertolive commented Jul 25, 2024

Description

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-mmi PRs from the MMI team label Jul 25, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [0ab3431]
Page Load Metrics (69 ± 10 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint6013096199
domContentLoaded95825147
load45120692010
domInteractive95825147
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link

sonarcloud bot commented Jul 26, 2024

@albertolive albertolive marked this pull request as ready for review July 26, 2024 09:12
@albertolive albertolive requested review from a team as code owners July 26, 2024 09:12
@metamaskbot
Copy link
Collaborator

Builds ready [e6b4fa8]
Page Load Metrics (253 ± 334 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint682501244622
domContentLoaded9179424722
load413274253695334
domInteractive9179424722
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link

codecov bot commented Jul 26, 2024

Codecov Report

Attention: Patch coverage is 95.45455% with 1 line in your changes missing coverage. Please review.

Project coverage is 69.94%. Comparing base (b27dd2b) to head (e6b4fa8).
Report is 8 commits behind head on develop.

Files Patch % Lines
...-token-page/interactive-replacement-token-page.tsx 95.45% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #26115   +/-   ##
========================================
  Coverage    69.94%   69.94%           
========================================
  Files         1409     1409           
  Lines        49794    49799    +5     
  Branches     13773    13773           
========================================
+ Hits         34826    34830    +4     
- Misses       14968    14969    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@albertolive albertolive merged commit 7cd38ed into develop Jul 29, 2024
97 checks passed
@albertolive albertolive deleted the MMI-5307-interactive-replacement-token-page-to-ts branch July 29, 2024 10:41
@github-actions github-actions bot locked and limited conversation to collaborators Jul 29, 2024
@metamaskbot metamaskbot added the release-12.4.0 Issue or pull request that will be included in release 12.4.0 label Jul 29, 2024
@gauthierpetetin gauthierpetetin added release-12.3.0 Issue or pull request that will be included in release 12.3.0 and removed release-12.4.0 Issue or pull request that will be included in release 12.4.0 labels Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.3.0 Issue or pull request that will be included in release 12.3.0 team-mmi PRs from the MMI team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants