-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: extract Send-specific functionality out of AssetPicker #26558
Conversation
3819a56
to
4430252
Compare
Builds ready [4430252]
Page Load Metrics (70 ± 17 ms)
Bundle size diffs
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #26558 +/- ##
===========================================
+ Coverage 70.08% 70.09% +0.01%
===========================================
Files 1413 1416 +3
Lines 49318 49352 +34
Branches 13780 13786 +6
===========================================
+ Hits 34562 34593 +31
- Misses 14756 14759 +3 ☔ View full report in Codecov by Sentry. |
4430252
to
5a0f942
Compare
Builds ready [5a0f942]
Page Load Metrics (1755 ± 70 ms)
Bundle size diffs
|
ui/components/multichain/asset-picker-amount/asset-picker-modal/types.ts
Outdated
Show resolved
Hide resolved
LGTM! Thank you 🙏 |
Quality Gate passedIssues Measures |
Builds ready [4dbfad9]
Page Load Metrics (1640 ± 48 ms)
Bundle size diffs
|
Description
The goal of this PR is to make the AssetPicker component experience-agnostic so that it can be reused within other experiences.
Since the AssetPicker was initially built for the Swap+Send experience, most changes here are for moving send-specific logic out of the component, including:
asset
prop, which contains the minimal required information about the selected assetRelated issues
Fixes: https://consensyssoftware.atlassian.net/browse/METABRIDGE-890
Manual testing steps
Screenshots/Recordings
Before -> After
Pre-merge author checklist
Pre-merge reviewer checklist