Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose a color prop for Text #2658

Closed
FrederikBolding opened this issue Aug 22, 2024 · 0 comments · Fixed by #2660 or MetaMask/metamask-extension#26675
Closed

Expose a color prop for Text #2658

FrederikBolding opened this issue Aug 22, 2024 · 0 comments · Fixed by #2660 or MetaMask/metamask-extension#26675
Assignees
@hmalik88
Labels
release-12.5.0 Issue or pull request that will be included in release 12.5.0

Comments

@FrederikBolding
Copy link
Member

FrederikBolding commented Aug 22, 2024 •
edited
Loading

We should consider exposing a color prop on Text, allowing devs to choose between a subset of color options.

For this initial version we should add the following colors: default, alternative, muted, error, success, warning
@FrederikBolding FrederikBolding changed the title Consider exposing a color prop for Text Expose a color prop for Text Aug 22, 2024
@hmalik88 hmalik88 mentioned this issue Aug 22, 2024
Merged
@hmalik88 hmalik88 self-assigned this Aug 22, 2024
@FrederikBolding FrederikBolding mentioned this issue Aug 27, 2024
Merged
FrederikBolding added a commit to MetaMask/metamask-extension that referenced this issue Aug 29, 2024
@FrederikBolding @hmalik88 @ritave
chore: Bump Snaps dependencies (#26675)
e177ba0 
## **Description**
Bump snaps packages to latest and handle breaking changes.

Summary of changes in the snaps deps:
- Add `Selector` component
- Add `Icon` component
- Add `color` prop to `Text` component
- `Button` children are now allowed to be `Image` and `Icon`

Closes MetaMask/snaps#2640
Closes MetaMask/MetaMask-planning#1615
Closes MetaMask/snaps#2658
Closes MetaMask/snaps#2639

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/26675?quickstart=1)

---------

Co-authored-by: Hassan Malik <41640681+hmalik88@users.noreply.github.com>
Co-authored-by: Olaf Tomalka <olaf@tomalka.me>
@metamaskbot metamaskbot added the release-12.5.0 Issue or pull request that will be included in release 12.5.0 label Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hmalik88 hmalik88

Labels
release-12.5.0 Issue or pull request that will be included in release 12.5.0
Projects
None yet
Milestone
No milestone
3 participants
@FrederikBolding @metamaskbot @hmalik88