Skip to content
This repository has been archived by the owner on Apr 22, 2024. It is now read-only.

Adding tests for etherscan #65

Merged
merged 1 commit into from
Apr 18, 2016
Merged

Conversation

Ryanmtate
Copy link

No description provided.

@danfinlay
Copy link
Contributor

If I remember right, these still aren't run as part of the main suite.

Do you have an opinion on that? Is it ok to add tests to the suite that are dependent on an external service?

@Ryanmtate
Copy link
Author

Ryanmtate commented Apr 17, 2016

I'll add tests for the main sub-providers; realize the etherscan tests may not be priority at the moment...

@Ryanmtate
Copy link
Author

This PR also contains a file change to hooked-wallet-ethtx.js:

const self = this

Received: ReferenceError: self is not defined when calling from eth-faucet project.

//

In the future, these should be separate PRs.

@kumavis
Copy link
Member

kumavis commented Apr 18, 2016

@Ryanmtate thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants