Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): add simple build workflow #914

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

dnwe
Copy link
Contributor

@dnwe dnwe commented Aug 27, 2024

Add a simple GitHub Action workflow which builds (and caches) the .devcontainer docker image and then runs a make of the MiSTer binary within it before uploading it as an artifact on the workflow result.

This provides a simple compilation test on pull requests and also allows the author or others to grab a built binary for testing purposes

@sorgelig
Copy link
Member

It's not a good idea to make a binary with every change in this repo.
There is unstable/nightly builds which is fine for those who want to test latest changes.

@dnwe
Copy link
Contributor Author

dnwe commented Aug 28, 2024

To be clear, the binary is only attached to the workflow result, it isn’t added to the repo or anything. It is mostly useful as confirmation that when someone has raised a PR their changes do compile. However, a side benefit is (for example) if someone submits a pull request to add support for a new steering wheel in input.cpp there’s also a binary available, build in a clean env, that can be linked to owner(s) of that wheel to test and confirm the changes are good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants