Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deploy with unrelated files in root directory #13

Merged
merged 2 commits into from
Feb 21, 2021

Conversation

lorenzoh
Copy link
Contributor

When running deploy in a folder that contains unrelated files, I've run into an error where it tries to check file/versions.js even though file is a file in the root directory and not a directory.

This small change filters out files when checking each versions.js. Please let me know if I've missed something.

Copy link
Owner

@MichaelHatherly MichaelHatherly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lorenzoh, just one inline comment to work out.

src/deploy.jl Outdated Show resolved Hide resolved
src/deploy.jl Outdated Show resolved Hide resolved
@MichaelHatherly MichaelHatherly merged commit e98da23 into MichaelHatherly:master Feb 21, 2021
@MichaelHatherly
Copy link
Owner

Thanks

@MichaelHatherly
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants